fix: enable paste html in compose box #53367

daledah · 2024-12-02T04:56:24Z

Explanation of Change

Fixed Issues

$ #52681
PROPOSAL: #52681 (comment)

Tests

Go to self DM
Type "> ga" in compose box and send
Long press sent message > copy to clipboard
Paste the text in compose box
Press plus icon > create expense > manual
Enter amount and press next
Paste text in the description field
Verify that: in step 4 and 7, correct markdown text is pasted.

Verify that no errors appear in the JS console

Offline tests

QA Steps

Go to self DM
Type "> ga" in compose box and send
Long press sent message > copy to clipboard
Paste the text in compose box
Press plus icon > create expense > manual
Enter amount and press next
Paste text in the description field
Verify that: in step 4 and 7, correct markdown text is pasted.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2024-12-02.at.12.08.53.mp4

Android: mWeb Chrome

Screen.Recording.2024-12-02.at.12.01.38.mp4

iOS: Native

Screen.Recording.2024-12-02.at.12.17.54.mov

iOS: mWeb Safari

Screen.Recording.2024-12-02.at.12.15.55.mov

MacOS: Chrome / Safari

Screen.Recording.2024-12-02.at.11.52.12.mov

MacOS: Desktop

Screen.Recording.2024-12-02.at.12.22.10.mov

melvin-bot · 2024-12-02T04:56:28Z

Hey! I see that you made changes to our Form component. Make sure to update the docs in FORMS.md accordingly. Cheers!

melvin-bot · 2024-12-02T06:46:08Z

@thesahindia Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

thesahindia · 2024-12-04T18:57:47Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2024-12-03.at.9.01.34.PM.mov

Android: mWeb Chrome

Screen.Recording.2024-12-03.at.8.50.29.PM.mov

iOS: Native

Screen.Recording.2024-12-03.at.9.03.52.PM.mov

iOS: mWeb Safari

Screen.Recording.2024-12-05.at.12.13.09.AM.mov

MacOS: Chrome / Safari

Screen.Recording.2024-12-05.at.12.17.33.AM.mov

MacOS: Desktop

Screen.Recording.2024-12-05.at.12.26.06.AM.mov

thesahindia

Tests well!

thesahindia

Tests well!

Looks like my internet is slow.

github-actions · 2024-12-05T15:17:31Z

🚀 Deployed to staging by https://github.com/flodnv in version: 9.0.72-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	success ✅

github-actions · 2024-12-05T16:02:38Z

🚀 Deployed to staging by https://github.com/flodnv in version: 9.0.72-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

stitesExpensify · 2024-12-05T16:45:41Z

I believe that this is related to this deploy blocker #53637

The console showed:

hook.js:608 Error: Couldn't find a navigation object. Is your component inside NavigationContainer?
    at c (index.ts:32:24)
    at X (index.tsx:107:5)
overrideMethod	@	hook.js:608
uA	@	react-dom.production.min.js:188
a.componentDidCatch.n.callback	@	react-dom.production.min.js:189
Ha	@	react-dom.production.min.js:156
Es	@	react-dom.production.min.js:260
Is	@	react-dom.production.min.js:259
ms	@	react-dom.production.min.js:258
(anonymous)	@	react-dom.production.min.js:282
yl	@	react-dom.production.min.js:280
il	@	react-dom.production.min.js:269
v	@	scheduler.production.min.js:13
k	@	scheduler.production.min.js:14
e.exports	@	_invoke.js:5
f.<computed>	@	_task.js:35
I	@	_task.js:21
E	@	_task.js:25

At c (which was modified here) is:

const useHtmlPaste: UseHtmlPaste = (textInputRef, preHtmlPasteCallback, removeListenerOnScreenBlur = false, isMarkdownEnabled = true) => {
    const navigation = useNavigation();

At x (which was added here) is:

useHtmlPaste(input as MutableRefObject<TextInput | null>, undefined, false, isMarkdownEnabled);

github-actions · 2024-12-09T16:05:53Z

🚀 Deployed to production by https://github.com/luacmartins in version: 9.0.72-1 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	failure ❌

fix: enable paste html in compose box

85bd242

fix: lint

5252494

daledah marked this pull request as ready for review December 2, 2024 06:46

daledah requested a review from a team as a code owner December 2, 2024 06:46

melvin-bot bot requested review from thesahindia and removed request for a team December 2, 2024 06:46

daledah mentioned this pull request Dec 2, 2024

[HOLD for payment 2024-12-16] [$250] mWeb - Chat - Quote markdown is not copied in compose box #52681

Open

8 tasks

thesahindia approved these changes Dec 4, 2024

View reviewed changes

melvin-bot bot requested a review from flodnv December 4, 2024 18:59

flodnv approved these changes Dec 4, 2024

View reviewed changes

flodnv merged commit 731cab1 into Expensify:main Dec 4, 2024
18 of 19 checks passed

This was referenced Dec 4, 2024

Investigate workflow job failing on main: test / test (job 2) #53601

Closed

Investigate workflow job failing on main: confirmPassingBuild #53602

Closed

Deploy Checklist: New Expensify 2024-12-05 #53631

Closed

stitesExpensify mentioned this pull request Dec 5, 2024

[$250] App crashes when clicking add reaction #53637

Closed

8 tasks

lanitochka17 mentioned this pull request Dec 5, 2024

[$250] Android - Live mark down is not rendered when Description field is opened after saving it #53645

Open

8 tasks

Tony-MK mentioned this pull request Dec 6, 2024

[$250] Profile - Email copied from profile is pasted twice in Private notes #53654

Closed

8 tasks

marcochavezf mentioned this pull request Dec 6, 2024

Revert "fix: enable paste html in compose box" #53675

Merged

48 tasks

daledah mentioned this pull request Dec 13, 2024

fix: enable paste html in compose box and fix regressions #53758

Open

50 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: enable paste html in compose box #53367

fix: enable paste html in compose box #53367

daledah commented Dec 2, 2024 •

edited

Loading

melvin-bot bot commented Dec 2, 2024

melvin-bot bot commented Dec 2, 2024

thesahindia commented Dec 4, 2024

thesahindia left a comment

thesahindia left a comment •

edited

Loading

github-actions bot commented Dec 5, 2024

github-actions bot commented Dec 5, 2024

stitesExpensify commented Dec 5, 2024

github-actions bot commented Dec 9, 2024

fix: enable paste html in compose box #53367

fix: enable paste html in compose box #53367

Conversation

daledah commented Dec 2, 2024 • edited Loading

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Dec 2, 2024

melvin-bot bot commented Dec 2, 2024

thesahindia commented Dec 4, 2024

Reviewer Checklist

Screenshots/Videos

thesahindia left a comment

Choose a reason for hiding this comment

thesahindia left a comment • edited Loading

Choose a reason for hiding this comment

github-actions bot commented Dec 5, 2024

github-actions bot commented Dec 5, 2024

stitesExpensify commented Dec 5, 2024

github-actions bot commented Dec 9, 2024

daledah commented Dec 2, 2024 •

edited

Loading

thesahindia left a comment •

edited

Loading