fix: clicking submit button makes flicking on a workspace with delay … #53541

jacobkim9881 · 2024-12-04T11:19:44Z

Explanation of Change

This PR fixes Submit button flicks on a workspace with delay. Flickering occurs for getMissingOnyxUpdates API call, so the fix keep Submit Report from calling the API.

Fixed Issues

$ #53226
PROPOSAL: $ #53226 (comment)

Tests

Verify that no errors appear in the JS console

Precondition

Create a workspace
Go to workspace Settings -> More features -> enable Workflow.
Go to workflow tab and enable Delay submissions.

Test

Go to the workspace and create/submit manual expense.
In WS chat click. "Submit" button on the expense preview.
Verify that the Submit button does not flicker.

Offline tests

QA Steps

Verify that no errors appear in the JS console

Precondition

Create a workspace
Go to workspace Settings -> More features -> enable Workflow.
Go to workflow tab and enable Delay submissions.

Test

Go to the workspace and create/submit manual expense.
In WS chat click. "Submit" button on the expense preview.
Verify that the Submit button does not flicker.

PR Author Checklist

Screenshots/Videos

Android: Native

expensify-test2-1-2024-12-04_18.31.10.mp4

Android: mWeb Chrome

expensify-test2-2-2024-12-04_18.38.31.mp4

iOS: Native

2024-12-04.8.14.40.mov

iOS: mWeb Safari

2024-12-04.8.52.24.mov

MacOS: Chrome / Safari

expensify-test2-0-2024-12-04_18.21.59.mp4

MacOS: Desktop

2024-12-04.7.09.16.mov

…submissions

melvin-bot · 2024-12-05T05:15:35Z

@rojiphil Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

rojiphil · 2024-12-09T11:01:56Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

MacOS: Chrome / Safari

53541-web-safari-001.mp4

MacOS: Desktop

53541-desktop-001.mp4

Android: Native

53541-android-native-001.mp4

Android: mWeb Chrome

53541-mweb-chrome-001.mp4

iOS: Native

53541-ios-native-001.mp4

iOS: mWeb Safari

53541-mweb-safari-001.mp4

rojiphil

Thanks @jacobkim9881 for the PR. And sorry for the delay in PR review here.
NAB but please add the following as step (3) in the tests so that QA is aware of the verification step.
Verify that the Submit button does not flicker
Also, please copy the Precondition to the QA steps.

@rafecolton The changes LGTM and works well too.
All yours for review. Thanks.

jacobkim9881 · 2024-12-09T11:25:18Z

@rojiphil Thanks for reviewing and I'll edit as soon.

rafecolton

LGTM

OSBotify · 2024-12-10T00:16:14Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2024-12-10T23:03:57Z

🚀 Deployed to staging by https://github.com/rafecolton in version: 9.0.74-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

github-actions · 2024-12-12T01:33:54Z

🚀 Deployed to production by https://github.com/luacmartins in version: 9.0.74-8 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	success ✅

arosiclair · 2024-12-19T20:11:39Z

src/libs/Middleware/SaveResponseInOnyx.ts

@@ -10,6 +10,7 @@ const requestsToIgnoreLastUpdateID: string[] = [
    SIDE_EFFECT_REQUEST_COMMANDS.RECONNECT_APP,
    WRITE_COMMANDS.CLOSE_ACCOUNT,
    WRITE_COMMANDS.DELETE_MONEY_REQUEST,
+    WRITE_COMMANDS.SUBMIT_REPORT,


@rafecolton @rojiphil @jacobkim9881 hey I noticed this change while investigating another issue. I don't have full context on this bug, but this is almost certainly the wrong way to fix it. We're essentially disabling reliable Onyx updates for SubmitReport requests here and ignoring any Onyx updates that may have been missed. I think we should revert this change and find another way to address the root problem.

😬 thanks Andrew. I agree that does not sound great, and I did not realize that's what this change would do. Let's revert. I commented on the issue.

No worries and thanks for raising the PR 🙇. Changes to this file aren't always obvious so maybe we should add a MelvinBot comment with a warning when a change is detected

Yeah I think that would be a good improvement

@arosiclair Thanks for reviewing. It makes me find an issue.

Thanks for reviewing. It makes me find an issue.

@jacobkim9881 Not sure if I understand. Can you please share the issue you found due to the change here?

Thanks for reviewing. It makes me find an issue.

@rojiphil It is revealed as unrelated from my side.

fix: clicking submit button makes flicking on a workspace with delay …

89dc9f5

…submissions

This comment was marked as off-topic.

Sign in to view

jacobkim9881 marked this pull request as ready for review December 5, 2024 05:15

jacobkim9881 requested a review from a team as a code owner December 5, 2024 05:15

melvin-bot bot requested a review from rojiphil December 5, 2024 05:15

melvin-bot bot removed the request for review from a team December 5, 2024 05:15

rafecolton assigned jacobkim9881 Dec 5, 2024

Merge branch 'main' of https://github.com/Expensify/App into m53226

f41129b

rojiphil approved these changes Dec 9, 2024

View reviewed changes

melvin-bot bot requested a review from rafecolton December 9, 2024 11:17

Merge branch 'main' of https://github.com/Expensify/App into m53226

4a52096

rafecolton approved these changes Dec 10, 2024

View reviewed changes

rafecolton merged commit bdbd322 into Expensify:main Dec 10, 2024
16 checks passed

FitseTLT mentioned this pull request Dec 10, 2024

[$250] Submit Expense - Submit button appears briefly In expense details page #53263

Closed

8 tasks

github-actions bot mentioned this pull request Dec 10, 2024

Deploy Checklist: New Expensify 2024-12-10 #53889

Closed

52 tasks

melvin-bot bot mentioned this pull request Dec 12, 2024

[HOLD for payment 2024-12-19] [$250] WS chat- "Pay with expensify" button blinks to Submit and back after clicking Submit #53226

Open

8 tasks

arosiclair reviewed Dec 19, 2024

View reviewed changes

arosiclair mentioned this pull request Dec 19, 2024

fix deleted expense still visible offline #49878

Merged

49 tasks

rafecolton mentioned this pull request Dec 19, 2024

Revert "fix: clicking submit button makes flicking on a workspace with delay …" #54395

Merged

jacobkim9881 mentioned this pull request Dec 22, 2024

fix: ignore Onyx update from GetMissingOnyxMessages for submit report #54450

Closed

50 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: clicking submit button makes flicking on a workspace with delay … #53541

fix: clicking submit button makes flicking on a workspace with delay … #53541

jacobkim9881 commented Dec 4, 2024 •

edited

Loading

This comment was marked as off-topic.

melvin-bot bot commented Dec 5, 2024

rojiphil commented Dec 9, 2024

rojiphil left a comment

jacobkim9881 commented Dec 9, 2024

rafecolton left a comment

OSBotify commented Dec 10, 2024

github-actions bot commented Dec 10, 2024

github-actions bot commented Dec 12, 2024

arosiclair Dec 19, 2024

rafecolton Dec 19, 2024

arosiclair Dec 19, 2024

rafecolton Dec 19, 2024

jacobkim9881 Dec 20, 2024

rojiphil Dec 20, 2024

This comment was marked as off-topic.

jacobkim9881 Dec 25, 2024

fix: clicking submit button makes flicking on a workspace with delay … #53541

fix: clicking submit button makes flicking on a workspace with delay … #53541

Conversation

jacobkim9881 commented Dec 4, 2024 • edited Loading

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

This comment was marked as off-topic.

melvin-bot bot commented Dec 5, 2024

rojiphil commented Dec 9, 2024

Reviewer Checklist

Screenshots/Videos

rojiphil left a comment

Choose a reason for hiding this comment

jacobkim9881 commented Dec 9, 2024

rafecolton left a comment

Choose a reason for hiding this comment

OSBotify commented Dec 10, 2024

github-actions bot commented Dec 10, 2024

github-actions bot commented Dec 12, 2024

arosiclair Dec 19, 2024

Choose a reason for hiding this comment

rafecolton Dec 19, 2024

Choose a reason for hiding this comment

arosiclair Dec 19, 2024

Choose a reason for hiding this comment

rafecolton Dec 19, 2024

Choose a reason for hiding this comment

jacobkim9881 Dec 20, 2024

Choose a reason for hiding this comment

rojiphil Dec 20, 2024

Choose a reason for hiding this comment

This comment was marked as off-topic.

jacobkim9881 Dec 25, 2024

Choose a reason for hiding this comment

jacobkim9881 commented Dec 4, 2024 •

edited

Loading