Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "fix: ProfileAvatar (modal) page has no slide in animation" #53784

Merged
merged 1 commit into from
Dec 9, 2024
Merged

Revert "fix: ProfileAvatar (modal) page has no slide in animation" #53784

merged 1 commit into from
Dec 9, 2024

Conversation

ishpaul777
Copy link
Contributor

@ishpaul777 ishpaul777 commented Dec 9, 2024 •
edited by luacmartins
Loading

Reverts #53475

Fixed issues:
$ #53777
$ #53772
$ #53780

This was referenced Dec 9, 2024
Closed
Merged
@ishpaul777 ishpaul777 marked this pull request as ready for review December 9, 2024 20:45
@ishpaul777 ishpaul777 requested a review from a team as a code owner December 9, 2024 20:45
@melvin-bot melvin-bot bot requested review from mjasikowski and removed request for a team December 9, 2024 20:45
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Dec 9, 2024

@mjasikowski Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@luacmartins
Copy link
Contributor

Merging since it's a straight revert

@luacmartins luacmartins merged commit 06abff8 into Expensify:main Dec 9, 2024
13 of 18 checks passed
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Dec 9, 2024

@luacmartins looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@melvin-bot melvin-bot bot added the Emergency label Dec 9, 2024
@luacmartins
Copy link
Contributor

Straight revert, not an emergency

@OSBotify
Copy link
Contributor

OSBotify commented Dec 9, 2024

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify pushed a commit that referenced this pull request Dec 9, 2024
@luacmartins @OSBotify
Merge pull request #53784 from ishpaul777/revert-53475-@chrispader/fi…
e2b3659 
…x-attachment-modal-screens-open-animation

Revert "fix: ProfileAvatar (modal) page has no slide in animation"

(cherry picked from commit 06abff8)

(CP triggered by luacmartins)
@github-actions github-actions bot added the CP Staging marks PRs that have been CP'd to staging label Dec 9, 2024
@github-actions github-actions bot mentioned this pull request Dec 9, 2024
Closed
70 tasks
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 9, 2024

🚀 Cherry-picked to staging by https://github.com/luacmartins in version: 9.0.73-6 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅
🤖🔄 android HybridApp 🤖🔄 success ✅
🍎🔄 iOS HybridApp 🍎🔄 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@github-actions GitHub Actions
Copy link
Contributor

🚀 Deployed to production by https://github.com/luacmartins in version: 9.0.73-8 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅
🤖🔄 android HybridApp 🤖🔄 success ✅
🍎🔄 iOS HybridApp 🍎🔄 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luacmartins luacmartins luacmartins approved these changes

@mjasikowski mjasikowski Awaiting requested review from mjasikowski

Assignees
No one assigned
Labels
CP Staging marks PRs that have been CP'd to staging
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ishpaul777 @luacmartins @OSBotify