-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix accounting tab load indefinitely #54110
Fix accounting tab load indefinitely #54110
Conversation
Reviewer Checklist
Screenshots/VideosAndroid: Native54110-android-native.mp4Android: mWeb Chrome54110-android-chrome.mp4iOS: Native54110-ios-native.mp4iOS: mWeb Safari54110-ios-safari.mp4MacOS: Chrome / Safari54110-mac-chrome.mp4MacOS: Desktop54110-mac-desktop.mp4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. :D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work thanks! I'll go ahead and merge. Let's please add some more comments with a quick follow up. I'll be OOO for the next week so you might want to find someone else to review it in the meantime.
@@ -580,4 +580,23 @@ describe('APITests', () => { | |||
expect(thirdRequestCommandName).toBe('MockCommandTwo'); | |||
}); | |||
}); | |||
|
|||
test('Read request should not stuck when SequentialQueue is paused an resumed', async () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NAB: It should say paused and resumed
@@ -128,7 +128,7 @@ function process(): Promise<void> { | |||
return currentRequestPromise; | |||
} | |||
|
|||
function flush() { | |||
function flush(shouldResetPromise = true) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NAB: Can you please add a doc comment explaining what this param does and why it's necessary. You could basically describe the RCA of the issue.
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/neil-marcellini in version: 9.0.77-0 🚀
|
🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.0.77-6 🚀
|
Explanation of Change
Fixed Issues
$ #52027
PROPOSAL: #52027 (comment)
Tests
Same as QA Steps
Offline tests
Same as QA Steps
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
android.mp4
Android: mWeb Chrome
android.mweb.mp4
iOS: Native
ios.mp4
iOS: mWeb Safari
ios.mweb.mp4
MacOS: Chrome / Safari
web.mp4
MacOS: Desktop
desktop.mp4