-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix input autofocus on Sage Intacct/NetSuite setup pages #54396
Fix input autofocus on Sage Intacct/NetSuite setup pages #54396
Conversation
Caused by setting a state on every render, which triggers another render.
@thesahindia Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Will review today! |
Reviewer Checklist
Screenshots/VideosAndroid: NativeScreen.Recording.2024-12-24.at.9.17.35.PM.movAndroid: mWeb ChromeScreen.Recording.2024-12-24.at.9.13.33.PM.moviOS: NativeScreen.Recording.2024-12-24.at.8.33.25.PM.moviOS: mWeb SafariScreen.Recording.2024-12-24.at.8.31.17.PM.movMacOS: Chrome / SafariScreen.Recording.2024-12-24.at.8.20.59.PM.movMacOS: DesktopScreen.Recording.2024-12-24.at.8.23.37.PM.mov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works well!
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/MonilBhavsar in version: 9.0.79-0 🚀
|
🚀 Deployed to production by https://github.com/puneetlath in version: 9.0.79-5 🚀
|
Explanation of Change
Adds input autofocus to Sage Intacct setup page.
Fixes an issue where autofocus stops working after closing and reopening the RHP.
Fixed Issues
$ #53314
$ #53156
PROPOSAL: #53156 (comment)
Tests
Same as QA Steps
Offline tests
N/A
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
53156.android.native.webm
Android: mWeb Chrome
53156.android.mWeb.webm
iOS: Native
53156.ios.native.mp4
iOS: mWeb Safari
53156.ios.safari.mp4
MacOS: Chrome / Safari
53156.macos.safari.mov
MacOS: Desktop
53156.macos.desktop.mov