Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Expensify Mono font and update code styling #54773

Merged
merged 2 commits into from
Jan 7, 2025
Merged

Add Expensify Mono font and update code styling #54773

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d592c1b
Add Expensify Mono font and update code styling
JoshIri360 Jan 2, 2025
34d31ff
Add correct fallback fonts
JoshIri360 Jan 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions docs/_sass/_fonts.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,20 @@
src: url('/assets/fonts/ExpensifyNewKansas-MediumItalic.woff2') format('woff2'), url('/assets/fonts/ExpensifyNewKansas-MediumItalic.woff') format('woff');
}

@font-face {
font-family: Expensify Mono;
font-weight: 400;
font-style: normal;
src: url('/assets/fonts/ExpensifyMono-Regular.woff2') format('woff2'), url('/assets/fonts/ExpensifyMono-Regular.woff') format('woff');
}

@font-face {
font-family: Expensify Mono;
font-weight: 700;
font-style: normal;
src: url('/assets/fonts/ExpensifyMono-Bold.woff2') format('woff2'), url('/assets/fonts/ExpensifyMono-Bold.woff') format('woff');
}

* {
-webkit-font-smoothing: antialiased;
-moz-osx-font-smoothing: grayscale;
Expand Down
17 changes: 16 additions & 1 deletion docs/_sass/_main.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,7 @@ details[open] > summary {

h1,
summary {
font-family: 'Expensify New Kansas', 'Helvetica Neue', 'Helvetica', Arial, sans-serif;
font-family: 'Expensify Mono', 'SFMono-Regular', monospace, Arial, sans-serif;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JoshIri360 why did we update the h1 styles to use mono?

Also, how is the summary tag used across the site? What does it do exactly?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think this was answered in the other PR, but this is all fixed now :)

font-weight: 500;
font-size: larger;
}
Expand All @@ -144,6 +144,21 @@ p {
padding-bottom: 20px;
}

code {
font-family: 'Expensify Mono', 'Helvetica Neue', 'Helvetica', Arial, sans-serif;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like the fallback fonts should be mono fonts and not helvetica, etc?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, yes I'll make that change.

border-width: 1px;
border-style: solid;
border-radius: 5px;
border-color: var(--color-borders);
background-color: var(--color-highlightBG);
line-height: 20px;
padding-left: 5px;
padding-right: 5px;
font-size: 13px;
shawnborton marked this conversation as resolved.
Show resolved Hide resolved
margin-top: 0px;
margin-bottom: 0px;
}

body,
button,
input,
Expand Down
Binary file added docs/assets/fonts/ExpensifyMono-Bold.woff
View file
Open in desktop
Binary file not shown.
Binary file added docs/assets/fonts/ExpensifyMono-Bold.woff2
View file
Open in desktop
Binary file not shown.
Binary file added docs/assets/fonts/ExpensifyMono-Regular.woff
View file
Open in desktop
Binary file not shown.
Binary file added docs/assets/fonts/ExpensifyMono-Regular.woff2
View file
Open in desktop
Binary file not shown.
Loading