-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CP staging] [No QA][HybridApp] Adjust Fastfile to HybridApp dotenv #54888
[CP staging] [No QA][HybridApp] Adjust Fastfile to HybridApp dotenv #54888
Conversation
@techievivek Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
We should merge OldDot PR first, then I think we can bump submodule commit here and merge this PR cc: @Julesssss |
I bumped submodule commit 👌 |
Reviewer Checklist
Screenshots/VideosAndroid: NativeAndroid: mWeb ChromeiOS: NativeiOS: mWeb SafariMacOS: Chrome / SafariMacOS: Desktop |
@mateuuszzzzz It says the branch has conflicts, but I can't see anything in the UI, can you please take a look. |
It must be outdated main on our fork. I'll try to sync it one more time |
@techievivek it should be fine now |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
…to-hybridapp-dotenv [No QA][HybridApp] Adjust Fastfile to HybridApp dotenv (cherry picked from commit f06dda7) (CP triggered by Julesssss)
🚀 Cherry-picked to staging by https://github.com/Julesssss in version: 9.0.82-1 🚀
|
🚀 Deployed to production by https://github.com/thienlnam in version: 9.0.82-12 🚀
|
Explanation of Change
This PR adjusted Fastlane to changes from this PR: https://github.com/Expensify/Mobile-Expensify/pull/13342
Fixed Issues
These changes are necessary in order to alight our workflows with the new .env changes: https://github.com/Expensify/Mobile-Expensify/pull/13342
Tests
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop