-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the start group button moves up #55020
Conversation
Reviewer Checklist
Screenshots/VideosAndroid: Nativeandroid.movAndroid: mWeb Chromemweb-chrome.moviOS: Nativeios.moviOS: mWeb Safarimweb-safari.movMacOS: Chrome / Safariweb.movMacOS: Desktopdesktop.mov |
Failing lint is unrelated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Even though the Lint errors are unrelated, can you please fix them in this PR? Thanks!
@tgolen Fixed now. |
src/pages/NewChatPage.tsx
Outdated
@@ -230,7 +231,7 @@ function NewChatPage() { | |||
if (isOptionInList) { | |||
newSelectedOptions = reject(selectedOptions, (selectedOption) => selectedOption.login === option.login); | |||
} else { | |||
newSelectedOptions = [...selectedOptions, {...option, isSelected: true, selected: true, reportID: option.reportID ?? '-1'}]; | |||
newSelectedOptions = [...selectedOptions, {...option, isSelected: true, selected: true, reportID: option.reportID ?? CONST.EMPTY_STRING}]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this one needs to be CONST.DEFAULT_NUMBER_ID
as well? I think going from -1
to an empty string would have some unintended consequences.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tgolen I updated.
Fix the start group button moves up (cherry picked from commit 5f4df80) (CP triggered by tgolen)
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Cherry-picked to staging by https://github.com/tgolen in version: 9.0.82-7 🚀
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes. |
🚀 Deployed to production by https://github.com/thienlnam in version: 9.0.82-12 🚀
|
Explanation of Change
Fix the start group button moves up
Fixed Issues
$ #54975
PROPOSAL: #54975 (comment)
Tests
Offline tests
Same
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Screen.Recording.2025-01-10.at.00.14.32.mov
Android: mWeb Chrome
Screen.Recording.2025-01-10.at.00.16.56.mov
iOS: Native
Screen.Recording.2025-01-10.at.00.15.06.mov
iOS: mWeb Safari
Screen.Recording.2025-01-10.at.00.16.02.mov
MacOS: Chrome / Safari
Screen.Recording.2025-01-10.at.00.17.48.mov
MacOS: Desktop
Screen.Recording.2025-01-10.at.00.20.03.mov