Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the PO box message in VBA flow #5558

Merged
merged 2 commits into from
Sep 28, 2021
Merged

Update the PO box message in VBA flow #5558

merged 2 commits into from
Sep 28, 2021

Conversation

mountiny
Copy link
Contributor

Details

Just updating a copy of one side note in VBA flow, see the linked issue for details.

Fixed Issues

$ #5332

Tests

  1. Go to workspace settings and click Get Started
  2. Follow these instructions to add pending bank account .
  3. Make sure that in the Company information, you see a note under the field saying PO boxes and mail drop addresses are not allowed

QA Steps

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

Mobile Web

Desktop

iOS

Android

@mountiny mountiny requested a review from a team September 28, 2021 15:06
@mountiny mountiny self-assigned this Sep 28, 2021
@MelvinBot MelvinBot requested review from aldo-expensify and removed request for a team September 28, 2021 15:06
aldo-expensify
aldo-expensify approved these changes Sep 28, 2021
View reviewed changes
Copy link
Contributor

@aldo-expensify aldo-expensify left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@aldo-expensify aldo-expensify merged commit 495ff7d into main Sep 28, 2021
@aldo-expensify aldo-expensify deleted the vit-N6polishUpdatePOCopy branch September 28, 2021 20:23
@OSBotify OSBotify mentioned this pull request Sep 28, 2021
Closed
16 tasks
@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @aldo-expensify in version: 1.1.2-9 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @timszot in version: 1.1.3-1 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aldo-expensify aldo-expensify aldo-expensify approved these changes

Assignees

@mountiny mountiny

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mountiny @OSBotify @aldo-expensify