Fix Changed File ESLint for #11685 #55697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @brunovjk, since this is just ESLint changes, I'll ask an internal engineer to review. Sorry for the noise |
|
Fixed ESLint for all the files from this list except for |
srikarparsi
commented
Jan 24, 2025
| const itemReportNameValuePairs = reportNameValuePairs?.[`${ONYXKEYS.COLLECTION.REPORT_NAME_VALUE_PAIRS}${reportID}`]; | ||
| const itemReportActions = reportActions?.[`${ONYXKEYS.COLLECTION.REPORT_ACTIONS}${reportID}`]; | ||
| const itemParentReportActions = reportActions?.[`${ONYXKEYS.COLLECTION.REPORT_ACTIONS}${itemFullReport?.parentReportID}`]; | ||
| const itemParentReportAction = itemParentReportActions?.[itemFullReport?.parentReportActionID ?? '-1']; | ||
| const itemParentReportAction = itemFullReport?.parentReportActionID ? itemParentReportActions?.[itemFullReport?.parentReportActionID] : undefined; |
There was a problem hiding this comment.
I used undefined here since that is what is done in this example
There was a problem hiding this comment.
I can't see the same pattern where you have linked, can you please cross-check and confirm if you have linked correctly?
There was a problem hiding this comment.
I don't see you doing the same for line 121? Is that because reportaction can be undefined but same is not true for report?
There was a problem hiding this comment.
Sorry had the wrong link, it's this one right here:
https://github.com/Expensify/App/blob/main/contributingGuides/STYLE.md#case-2-type-undefined-cannot-be-used-as-an-index-type
There was a problem hiding this comment.
Thanks, that looks good to me. 👍
srikarparsi
commented
Jan 24, 2025
| ? ReportActionsUtils.getOriginalMessage(itemParentReportAction)?.IOUTransactionID ?? '-1' | ||
| : '-1'; | ||
| const transactionID = isMoneyRequestAction(itemParentReportAction) | ||
| ? getOriginalMessage(itemParentReportAction)?.IOUTransactionID ?? CONST.DEFAULT_NUMBER_ID |
There was a problem hiding this comment.
I used CONST.DEFAULT_NUMBER_ID here since that is what is done here
Reviewer Checklist
Screenshots/VideosN/A removing duplicate code Android: NativeAndroid: mWeb ChromeiOS: NativeiOS: mWeb SafariMacOS: Chrome / SafariMacOS: Desktop |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
82 tasks
|
🚀 Deployed to staging by https://github.com/techievivek in version: 9.0.90-0 🚀
|
Closed
8 tasks
|
🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.0.90-6 🚀
|
paultsimura
reviewed
Feb 11, 2025
| @@ -182,15 +190,15 @@ function BaseReportActionContextMenu({ | |||
| const [parentReportNameValuePairs] = useOnyx(`${ONYXKEYS.COLLECTION.REPORT_NAME_VALUE_PAIRS}${childReport?.parentReportID}`); | |||
| const [parentReport] = useOnyx(`${ONYXKEYS.COLLECTION.REPORT}${childReport?.parentReportID}`); | |||
|
|
|||
| const isMoneyRequest = useMemo(() => ReportUtils.isMoneyRequest(childReport), [childReport]); | |||
| const isTrackExpenseReport = ReportUtils.isTrackExpenseReport(childReport); | |||
| const isMoneyRequest = useMemo(() => ReportUtilsIsMoneyRequestReport(childReport), [childReport]); | |||
There was a problem hiding this comment.
We should have used ReportUtilsIsMoneyRequest here. Context: #55827 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Fixed Issues
$ #55658
PROPOSAL:
Tests
N/A ESLint Change
Offline tests
N/A ESLint Change
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
N/A ESLint Change
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop