Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrected: IOU - Unable to enter some combination of decimal numbers #5628

Merged
merged 1 commit into from
Oct 5, 2021

Conversation

PrashantMangukiya
Copy link
Contributor

@puneetlath and @deetergp pr is ready for review.

Details

User was not able to enter some combination of amount, so corrected that problem.

Fixed Issues

$ #5579

Tests | QA Steps

  1. Run app on any platform
  2. Navigate to a conversation
  3. Click on the + button in the compose box.
  4. Select Request Money
  5. Try to enter 19.1, 19.4, 19.6, 19.9 or try to enter 1, 4, 6, 9 after decimal point for the numbers 16, 17, 18 (18.4 or 17.9)

Now User will be able to enter any combination of decimal numbers.

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

Web.mov

Mobile Web

Mobile.Web.mov

Desktop

Desktop.mov

iOS

iOS.mov

Android

Android.mov

Copy link
Contributor

@deetergp deetergp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good and tests well.

@deetergp deetergp merged commit befde32 into Expensify:main Oct 5, 2021
@OSBotify
Copy link
Contributor

OSBotify commented Oct 5, 2021

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

OSBotify commented Oct 6, 2021

🚀 Deployed to staging by @deetergp in version: 1.1.5-2 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

OSBotify commented Oct 7, 2021

🚀 Deployed to production by @chiragsalian in version: 1.1.6-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants