Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Native Share Provisioning] Add ADHOC share extension profile to fastfile / build script #56684

Merged
merged 8 commits into from
Feb 12, 2025
Merged

[Native Share Provisioning] Add ADHOC share extension profile to fastfile / build script #56684

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
54e93e9
add ADHOC share extension to settings
grgia Feb 11, 2025
f4e80f4
Newdot ShareViewController
grgia Feb 11, 2025
107d076
xcode commits
grgia Feb 11, 2025
a3cbc2b
add production profile
grgia Feb 11, 2025
3e6033d
unstage xcode proj changes
grgia Feb 11, 2025
5814245
add newapp prod op
grgia Feb 11, 2025
272ec17
Merge branch 'main' into georgia-fastfile
grgia Feb 11, 2025
fb7899b
match pattern
grgia Feb 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/deploy.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -377,6 +377,7 @@ jobs:
run: |
op read "op://${{ vars.OP_VAULT }}/NewApp_AppStore/NewApp_AppStore.mobileprovision" --force --out-file ./NewApp_AppStore.mobileprovision
op read "op://${{ vars.OP_VAULT }}/NewApp_AppStore_Notification_Service/NewApp_AppStore_Notification_Service.mobileprovision" --force --out-file ./NewApp_AppStore_Notification_Service.mobileprovision
op read "op://${{ vars.OP_VAULT }}/NewApp_AppStore_Share_Extension.mobileprovision/NewApp_AppStore_Share_Extension.mobileprovision" --force --out-file ./NewApp_AppStore_Share_Extension.mobileprovision
op read "op://${{ vars.OP_VAULT }}/New Expensify Distribution Certificate/Certificates.p12" --force --out-file ./Certificates.p12
op read "op://${{ vars.OP_VAULT }}/ios-fastlane-json-key.json/ios-fastlane-json-key.json" --force --out-file ./ios-fastlane-json-key.json

Expand Down Expand Up @@ -500,7 +501,7 @@ jobs:
run: |
op read "op://${{ vars.OP_VAULT }}/firebase.json/firebase.json" --force --out-file ./firebase.json
op read "op://${{ vars.OP_VAULT }}/OldApp_AppStore/OldApp_AppStore.mobileprovision" --force --out-file ./OldApp_AppStore.mobileprovision
op read "op://${{ vars.OP_VAULT }}/OldApp_AppStore_Share_Extension/OldApp_AppStore_Share_Extension.mobileprovision" --force --out-file ./OldApp_AppStore_Share_Extension.mobileprovision
op read "op://${{ vars.OP_VAULT }}/OldApp_AppStore_Share_Extension.mobileprovision/OldApp_AppStore_Share_Extension.mobileprovision" --force --out-file ./OldApp_AppStore_Share_Extension.mobileprovision
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this was right before. Looking in the 1P vault, the NewApp item is called NewApp_AppStore_Share_Extension.mobileprovision, while the OldApp item does not have the mobileprovision suffix:

image image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for double checking!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I renamed the share extension ones to remove the .mobileprovision from the title because it's confusing

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I.e.
Screenshot 2025-02-12 at 11 34 30 AM

op read "op://${{ vars.OP_VAULT }}/OldApp_AppStore_Notification_Service/OldApp_AppStore_Notification_Service.mobileprovision" --force --out-file ./OldApp_AppStore_Notification_Service.mobileprovision
op read "op://${{ vars.OP_VAULT }}/ios-fastlane-json-key.json/ios-fastlane-json-key.json" --force --out-file ./ios-fastlane-json-key.json
op read "op://${{ vars.OP_VAULT }}/New Expensify Distribution Certificate/Certificates.p12" --force --out-file ./Certificates.p12
Expand Down
10 changes: 10 additions & 0 deletions fastlane/Fastfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -353,6 +353,10 @@ platform :ios do
path: "./NewApp_AppStore_Notification_Service.mobileprovision"
)

install_provisioning_profile(
path: "./NewApp_AppStore_Share_Extension.mobileprovision"
)

build_app(
workspace: "./ios/NewExpensify.xcworkspace",
scheme: "New Expensify",
Expand All @@ -361,6 +365,7 @@ platform :ios do
provisioningProfiles: {
"com.chat.expensify.chat" => "(NewApp) AppStore",
"com.chat.expensify.chat.NotificationServiceExtension" => "(NewApp) AppStore: Notification Service",
"com.chat.expensify.chat.ShareViewController" => "(NewApp) AppStore: Share Extension",
},
manageAppVersionAndBuildNumber: false
}
Expand Down Expand Up @@ -485,6 +490,10 @@ platform :ios do
path: "./NewApp_AdHoc_Notification_Service.mobileprovision"
)

install_provisioning_profile(
path: "./NewApp_AdHoc_Share_Extension.mobileprovision"
)

build_app(
workspace: "./ios/NewExpensify.xcworkspace",
skip_profile_detection: true,
Expand All @@ -495,6 +504,7 @@ platform :ios do
provisioningProfiles: {
"com.expensify.chat.adhoc" => "(NewApp) AdHoc",
"com.expensify.chat.adhoc.NotificationServiceExtension" => "(NewApp) AdHoc: Notification Service",
"com.expensify.chat.adhoc.ShareViewController" => "(NewApp) AdHoc: Share Extension",
},
manageAppVersionAndBuildNumber: false
}
Expand Down
Loading