-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[No QA] Clean out unused routes #5736
Conversation
cc @iwiznia 99% sure none of these routes are used anymore since we moved to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, I think these are all unsued now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like a thorough clean up 👍
Not merging due to N6 hold, just to be safe. |
N6 hold is over, merging. |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by @Julesssss in version: 1.1.8-10 🚀
|
🚀 Deployed to production by @roryabraham in version: 1.1.10-2 🚀
|
I think the Maybe we assumed that because other routes with a App/src/pages/ValidateLoginPage.js Lines 18 to 30 in 79eafd4
|
Details
Removes a number of unused screens and routes.
Fixed Issues
$ none, just general cleanup.
Tests
Just general regression testing. Run the app and make sure various routes work.
QA Steps
None – just regression testing.
Tested On