Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Made workspace invite and remove buttons small #5857

Merged
merged 1 commit into from
Oct 14, 2021
Merged

Made workspace invite and remove buttons small #5857

merged 1 commit into from
Oct 14, 2021

Conversation

akshayasalvi
Copy link
Contributor

@akshayasalvi akshayasalvi commented Oct 14, 2021 •
edited
Loading

Details

  • Made workspace invite and remove buttons small

Fixed Issues

$ #5811

Tests

  1. Checked sizes in all platforms

QA Steps

  1. Go to any workspace via Sidebar
  2. Click on Manage Members
  3. Invite and Remove button sizes should be standard small with proper padding

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

web-wkspace-button-size

Mobile Web

mweb-wkspace-button-size

Desktop

desktop-wkspace-button-size

iOS

ios-wkspace-button-size

Android

android-wkspace-button-size

@akshayasalvi akshayasalvi requested a review from a team as a code owner October 14, 2021 19:03
@MelvinBot MelvinBot requested review from pecanoro and removed request for a team October 14, 2021 19:03
@pecanoro pecanoro merged commit c9faa1b into Expensify:main Oct 14, 2021
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify OSBotify mentioned this pull request Oct 15, 2021
Closed
@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @pecanoro in version: 1.1.7-25 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@ogumen
Copy link

ogumen commented Oct 22, 2021

  1. Both buttons fail minimum color contrast requirements for small text (4.50:1). The white "Invite" text (#FFFFFF) against green button background (#03D47D) has a color contrast ratio of 1.95:1. The white "Remove" text (#FFFFFF) against red button background (#FC3826) has a color contrast of 3.66:1. This fails WCAG SC 1.4.3
    Expensify_Manage members_Buttons fail color contrast
  2. Buttons do not announce their button role when using the screen reader, thus the screen reader users are not aware that these elements are interactive. It fails WCAG SC 4.1.2
    Expensify_Manage members_The buttons announced without any role

@botify botify mentioned this pull request Oct 23, 2021
Closed
@OSBotify
Copy link
Contributor

🚀 Deployed to production by @roryabraham in version: 1.1.8-9 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pecanoro pecanoro pecanoro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@akshayasalvi @OSBotify @ogumen @pecanoro