-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove pointer events from label, modify styling of textinput #5858
Remove pointer events from label, modify styling of textinput #5858
Conversation
…h style of autofill
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Please CP staging this. @timszot |
@AlfredoAlc Please attach screenshots of all platforms if even if autofill does not work on all but you can attach normal view. |
|
Hold on. I need to check something. @AlfredoAlc Did you test it with autofill on the web? Do attach that screen? Thanks. |
@parasharrajat I couldn't find AndroidiOSDesktopWeb |
Ok. No worries, I just wanted to see the autofill working. Thanks for the screens. You can attach these to the main details so that they are easier to find. I think they look fine. Previously the autofill color was only filling in the input area but now it's covering the whole input. It does not seem a big deal to me. So 👍 . All yours @timszot. |
(cherry picked from commit 1ace10c)
@AlfredoAlc @parasharrajat Can you share steps to QA this PR |
You can follow the steps for #5704.
|
🚀 Deployed to production by @roryabraham in version: 1.1.8-9 🚀
|
with 1Password and a card saved, on the add payment method screen you can add a debit card. letting 1password fill this in triggers the blue background |
@parasharrajat @marcaaron
Details
To fix the initial issue of the label being able to be selected and to loose focus when clicking on it, I set the prop
pointerEvents
tonone
. This allows to remove thezIndex
prop, and I also removed theselectable
prop since it has no use now.For the issue where the autofill expands beyond the edges, I don't think it was related with the changes I made since I tested it with the same props that had before and actually the result was this:
But I passed the
borderRadius
from the container to theTextInput
and added aheight
since if no height is set, the blue background overlaps the border from the container. Also removed the...spacing.pv0
because it haspaddings
props so it had no use.Fixed Issues
$ #4515
$ #5704
Tested On
Screenshots
Android
iOS
Desktop
Web