Workspace Settings page - Fix offline behavior

[jasperhuangg]

Previously, when clicking "Save" on the workspace settings page, we'd only update Onyx after the promise to the UpdatePolicy API command resolved. When this happened offline, the promise would never resolve, meaning we'd never update isPolicyUpdating for the policy in Onyx, leading to a confusing infinite spinner.

Let's update the local values directly for the workspace and queue the API request in the background. This means that the local values will be updated while offline, and the queued API command will be made once the user goes back online.

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/180965

Tests

1. Navigate to the "Workspace Settings" page.
2. Turn off your internet connection for the device you're using.
3. Update the currency and name for the workspace. Click "Save".
4. Verify a success growl appears. Then, turn your internet connection back on.
5. Reload the page or re-open the app.
6. Verify that the updated currency, avatarURL, and name are displayed.

QA Steps

1. Navigate to the "Workspace Settings" page.
2. Turn off your internet connection for the device you're using.
3. Update the currency and name for the workspace. Click "Save".
4. Verify a success growl appears. Then, turn your internet connection back on, and give the app a few seconds to make any failed API calls that were queued offline.
5. Reload the page or close/re-open the app.
6. Verify that the updated currency, avatarURL, and name are displayed.

Tested On

• Web
• Mobile Web
• Desktop
• iOS
• Android

Screenshots

Web

web.mp4

Mobile Web

mweb.mov

Desktop

desktop.mp4

iOS

ios.mp4

Android

android.mp4

[jasperhuangg]

@aldo-expensify Good for a review, thanks!

[aldo-expensify]

Tested on web, the code changes look good to me!

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[OSBotify]

🚀 Deployed to staging by @aldo-expensify in version: 1.1.8-10 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

[OSBotify]

🚀 Deployed to production by @roryabraham in version: 1.1.10-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅