Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure we go to settings page rather than card route when creating a new workspace #5908

Merged
merged 1 commit into from
Oct 16, 2021
Merged

Make sure we go to settings page rather than card route when creating a new workspace #5908

merged 1 commit into from
Oct 16, 2021

Conversation

yuwenmemon
Copy link
Contributor

@yuwenmemon yuwenmemon commented Oct 16, 2021 •
edited
Loading

@TomatoToaster please review

Details

We were navigating to the card route but as @MitchExpensify says here it should be navigating to the Workspace editor page.

Fixed Issues

None

Tests

  1. Log into a NewDot account without a Workspace
  2. Click on Create New Workspace after clicking on the green + at the bottom left
  3. Verify a workspace is created and you are taken to the settings page

@yuwenmemon yuwenmemon self-assigned this Oct 16, 2021
@yuwenmemon yuwenmemon requested a review from a team as a code owner October 16, 2021 00:29
@MelvinBot MelvinBot requested review from HorusGoul and removed request for a team October 16, 2021 00:29
@github-actions
Copy link
Contributor

⚠️ ⚠️ Heads up! This pull request has the CP Staging label. ⚠️ ⚠️
Merging it will cause it to be immediately deployed to staging, even if the open StagingDeployCash deploy checklist is locked.

@yuwenmemon yuwenmemon requested a review from francoisl October 16, 2021 00:43
@yuwenmemon yuwenmemon merged commit 7062f9a into main Oct 16, 2021
@yuwenmemon yuwenmemon deleted the yuwen-settingsPage branch October 16, 2021 01:16
github-actions bot pushed a commit that referenced this pull request Oct 16, 2021
@yuwenmemon
Merge pull request #5908 from Expensify/yuwen-settingsPage
ec877c0 
Make sure we go to settings page rather than card route when creating a new workspace

(cherry picked from commit 7062f9a)
This was referenced Oct 16, 2021
Merged
Closed
@OSBotify
Copy link
Contributor

🚀 Cherry-picked to staging by @yuwenmemon in version: 1.1.8-2 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@OSBotify OSBotify mentioned this pull request Oct 23, 2021
Closed
@OSBotify
Copy link
Contributor

🚀 Deployed to production by @roryabraham in version: 1.1.8-9 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @yuwenmemon in version: 1.1.8-10 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @roryabraham in version: 1.1.10-2 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify OSBotify mentioned this pull request Aug 16, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomatoToaster TomatoToaster TomatoToaster approved these changes

@francoisl francoisl francoisl approved these changes

@HorusGoul HorusGoul Awaiting requested review from HorusGoul

Assignees

@yuwenmemon yuwenmemon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yuwenmemon @OSBotify @francoisl @TomatoToaster