Show first & last name length errors on front end #5963
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Beamanator
changed the title
nickmurray47
suggested changes
Oct 20, 2021
|
Responded & resolved comments, fixed eslint issues, back on track! Looks like iOS e2e failing is due to this: https://expensify.slack.com/archives/C01GTK53T8Q/p1634754414008400 |
…engthErrorsOnFrontEnd
|
Tests passed! 💪 |
|
Updated! 👍 |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by @nickmurray47 in version: 1.1.8-10 🚀
|
|
🚀 Deployed to production by @roryabraham in version: 1.1.10-2 🚀
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Idea coming from here: #5091 (comment) - we're starting to standardize showing input errors when submitting the form - validating on the front end instead of on the back-end. This speeds up users seeing errors and prevents some unnecessary API calls.
Related Issues
Related to: #5091
Tests
Profile page:
2. Open your profile page (Settings -> Profile)
3. Add a first & last name over 50 characters (ex:
012345678901234567890123456789012345678901234567890)4. Try to save the form, verify you see red outlined fields & errors under each
-
5. Change your first name to be between 0 and 50 characters
6. Resubmit the form, verify you only see the last name field with red outline & error underneath
7. Change your last name to be between 0 and 50 characters
8. Resubmit the form, verify there's no errors and you see the success growl
Request call page:
QA Steps
Same as above
Tested On
Screenshots
Web
Profile Page:
Request a call:
Screen.Recording.2021-10-20.at.11.47.05.AM.mov
Mobile Web
Profile Page:
Request a call:
Screen.Recording.2021-10-20.at.12.20.57.PM.mov
Desktop
Profile Page:
Request a call:
Screen.Recording.2021-10-20.at.12.06.21.PM.mov
iOS
Profile Page:
Request a call:
Screen.Recording.2021-10-20.at.12.17.39.PM.mov
Android
Profile Page:
Request a call:
Screen.Recording.2021-10-20.at.12.09.58.PM.mov