-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert isUnread logic to unreadActionCount. Improve LHN unread chat stability. #597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcaaron
commented
Oct 6, 2020
tgolen
reviewed
Oct 6, 2020
Ok this one is ready for another review. |
tgolen
previously approved these changes
Oct 6, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! We're gonna have conflicts :D Let's see who gets their's merged first.
tgolen
approved these changes
Oct 7, 2020
50 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrating some changes over from #525 which went off the rails
Wanted to take a step back and focus on improving the stability of the unread indicators in the LHN before adding any UI that will display their specific counts. Will be attempting to fix one or two bugs in the process.
Fixed Issues
Fixes https://github.com/Expensify/Expensify/issues/142988
Possibly Related to https://github.com/Expensify/Expensify/issues/142727
Tests
Test that leaving comments on a report works as expected
Test that a chat will show in the LHN if a new comment has been left on it while RNC is not running at all
e.cash
sessione.cash
session againTest that a chat will show in the LHN if a new comment has been left on it and RNC is running
Test that reconnection callbacks will reveal a chat in LHN on reconnect
Pusher.init()
line inHomePage
Screenshots
❌