Default to target=_blank for report comment links #601
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @Jag96
Quick fix here. Couldn't think of any reason why we'd need to open a report comment link in app for now so providing defaults for now to prevent people from getting stuck viewing files in the desktop app. Discussed with @Jag96 and the only reason we could think of is that file downloads will bypass the default "Save as..." prompt that shows in Electron. But there's no clear reason why it's better to do that than just opening these links in Chrome for now.
This logic might need to change if we have report comments that are intended to deep link to various places in the app. But that seems like a future problem.
Fixed Issues
Fixes https://github.com/Expensify/Expensify/issues/142225
Tests
.zip
attachment and a.txt
attachmentScreenshots
❌