Code

Added Keyboard shortcuts modal#6112

Code

Merged

roryabraham merged 41 commits intoExpensify:mainExpensify/App:mainfrom akshayasalvi:keyboard-shortcuts-modalakshayasalvi/App:keyboard-shortcuts-modalCopy head branch name to clipboardNov 24, 2021

+315-19

Commits

Commits on Oct 29, 2021

• Basic component with props added

  akshayasalvi

  committed
  baf320a

  Copy full SHA for baf320a

• Converted component to class component

  akshayasalvi

  committed
  fdf81af

  Copy full SHA for fdf81af

• Added mapper function to the keyboardshortcut lib

  akshayasalvi

  committed
  e00816c

  Copy full SHA for e00816c

• Translation files

  akshayasalvi

  committed
  28855fb

  Copy full SHA for 28855fb

• Removed modal props from ScreenWrapper

  akshayasalvi

  committed
  cb54938

  Copy full SHA for cb54938

• Modified the shortcut trigger logic to modal

  akshayasalvi

  committed
  a6c28bd

  Copy full SHA for a6c28bd

• Added keys for existing shortcuts

  akshayasalvi

  committed
  6bad775

  Copy full SHA for 6bad775

• Styling updates for container

  akshayasalvi

  committed
  290acb8

  Copy full SHA for 290acb8

• Key handling for cmd

  akshayasalvi

  committed
  f31f5ed

  Copy full SHA for f31f5ed

• Moved styling to style.js

  akshayasalvi

  committed
  2b6e319

  Copy full SHA for 2b6e319

• Changed border styling

  akshayasalvi

  committed
  32622ab

  Copy full SHA for 32622ab

• Added spanish translations

  akshayasalvi

  committed
  2e0d4c7

  Copy full SHA for 2e0d4c7

Commits on Nov 3, 2021

• Added styling options for modal

  akshayasalvi

  committed
  2096196

  Copy full SHA for 2096196

• Added borderRadius to the table

  akshayasalvi

  committed
  18fbadf

  Copy full SHA for 18fbadf

• Fixed border styling for the table

  akshayasalvi

  committed
  640687d

  Copy full SHA for 640687d

• Removed height hardcoding

  akshayasalvi

  committed
  c18e2a4

  Copy full SHA for c18e2a4

Commits on Nov 7, 2021

• Allow modal to open in input focus as well

  akshayasalvi

  committed
  ea2a41f

  Copy full SHA for ea2a41f

• Merge branch 'main' of github-personal:akshayasalvi/App into keyboard-shortcuts-modal

  Show description for e1a8e96
  akshayasalvi

  committed
  e1a8e96

  Copy full SHA for e1a8e96

• Updated copy for the modal subtitle

  akshayasalvi

  committed
  e39b198

  Copy full SHA for e39b198

Commits on Nov 8, 2021

• Code cleanup

  akshayasalvi

  committed
  77c9381

  Copy full SHA for 77c9381

• Moved object to map to Keyboardshortcut lib

  akshayasalvi

  committed
  111edbc

  Copy full SHA for 111edbc

• Reordered params for KeyboardShortcut.subscribe

  akshayasalvi

  committed
  06e42c4

  Copy full SHA for 06e42c4

• Styling fixes

  akshayasalvi

  committed
  1018fb5

  Copy full SHA for 1018fb5

• Changes for code cleanup

  akshayasalvi

  committed
  dbfa47e

  Copy full SHA for dbfa47e

• Merge branch 'main' of github-personal:akshayasalvi/App into keyboard-shortcuts-modal

  Show description for 048c729
  akshayasalvi

  committed
  048c729

  Copy full SHA for 048c729

• Added check for descriptionKey

  akshayasalvi

  committed
  666e499

  Copy full SHA for 666e499

• Fixed escape key for dialog

  akshayasalvi

  committed
  eeb16d1

  Copy full SHA for eeb16d1

• Lint fixes

  akshayasalvi

  committed
  fa76933

  Copy full SHA for fa76933

• Made modal bottom docked for small screens and changed function name

  akshayasalvi

  committed
  99e7a4f

  Copy full SHA for 99e7a4f

Commits on Nov 9, 2021

• Moved shortcut modifiers (control/meta) logic to utils

  akshayasalvi

  committed
  1f57f37

  Copy full SHA for 1f57f37

Commits on Nov 14, 2021

• Merge branch 'main' of github-personal:akshayasalvi/App into keyboard-shortcuts-modal

  Show description for 6943aa1
  akshayasalvi

  committed
  6943aa1

  Copy full SHA for 6943aa1

Commits on Nov 19, 2021

• Changed logic for modifiers

  akshayasalvi

  committed
  4c29fc0

  Copy full SHA for 4c29fc0

• Fixed typo for KeyboardShortcut

  akshayasalvi

  committed
  7de6c54

  Copy full SHA for 7de6c54

• Split toggle func to hide and show

  akshayasalvi

  committed
  e5b034d

  Copy full SHA for e5b034d

• Removed hardcoding of the shortcuts to CONST

  akshayasalvi

  committed
  3cbd1bf

  Copy full SHA for 3cbd1bf

• Pick all shortcut configs from CONST

  akshayasalvi

  committed
  fc03898

  Copy full SHA for fc03898

• Added enter configuration for keyboard shortcuts

  akshayasalvi

  committed
  eb6ef1c

  Copy full SHA for eb6ef1c

• Fixed typo for Button

  akshayasalvi

  committed
  e2e456c

  Copy full SHA for e2e456c

Commits on Nov 23, 2021

• Added jsdocs and changed function calls

  akshayasalvi

  committed
  f09b027

  Copy full SHA for f09b027

• Unified representation of shortcut object

  akshayasalvi

  committed
  2eeed69

  Copy full SHA for 2eeed69

• Fixed typos in shortcuts

  akshayasalvi

  committed
  06c77ce

  Copy full SHA for 06c77ce