Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sign out button, by passing reference when removing event #613

Closed

Conversation

Julesssss
Copy link
Contributor

@Julesssss Julesssss commented Oct 7, 2020

CC @marcaaron

Fixed Issues

Fixes https://github.com/Expensify/Expensify/issues/143067

Fixes issue where sign out button threw error and did not return user to login page.

sign-out-blocked

Tests (Desktop and web)

  • Sign in to an account
  • Attempt to sign out
  • You should be returned to the login page

Screenshots

N/A

@Julesssss Julesssss requested a review from a team October 7, 2020 14:18
@Julesssss Julesssss self-assigned this Oct 7, 2020
@botify botify requested review from sketchydroide and removed request for a team October 7, 2020 14:18
@tgolen
Copy link
Contributor

tgolen commented Oct 7, 2020

I think Marc already fixed this in #609 so I'm going to close this.

@Julesssss
Copy link
Contributor Author

I think Marc already fixed this in #609 so I'm going to close this.

Ah thanks. I couldn't find a reference to this issue (maybe should have searched more thoroughly), I know it was a small thing, but an issue might have prevented this dupe.

@Julesssss Julesssss closed this Oct 7, 2020
@Julesssss Julesssss deleted the jules-fix-logout-with-listener-removal-reference branch October 22, 2021 11:24
@MelvinBot MelvinBot mentioned this pull request Jan 29, 2024
50 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants