Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove autofocus from the Edit messages and focus on the manual action #6138

Merged
merged 1 commit into from
Nov 4, 2021

Conversation

parasharrajat
Copy link
Member

@parasharrajat parasharrajat commented Oct 31, 2021

Details

Issues

  1. Keyboard does not open on android. [$1000] Android - Keyboard is not automatically displayed when editing a comment  #5637

Fixed Issues

$ #5896

Tests | QA Steps

  1. Open a report on Mobile.
  2. Edit a recent message visible on the screen. Input should be focused.
  3. Scroll back in the history. Edit any message.
  4. Edit another message.
  5. Go back to LHN.
  6. Switch to another chat.
  7. back to LHN.
  8. Open the first report.
  9. Now You should see the edit boxes for the last edit messages. But no focus should be placed automatically.
  10. Scroll back in the history until you reach the message that was edited. No keyboard should be shown while scrolling.

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web | Desktop

output_file.mp4

Mobile Web

output_file.mp4

iOS

Android

output_file.mp4

@parasharrajat
Copy link
Member Author

parasharrajat commented Nov 4, 2021

Unfortunately, my Mac's network interface settings got corrupted, and thus I am not able to test it. But I am sure that it works without issues on IOS.

Copy link
Contributor

@NikkiWines NikkiWines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good and tests well

@NikkiWines NikkiWines merged commit 6d1979b into Expensify:main Nov 4, 2021
@OSBotify
Copy link
Contributor

OSBotify commented Nov 4, 2021

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @NikkiWines in version: 1.1.14-5 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @AndrewGable in version: 1.1.15-15 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants