Use git+https when loading expensify-common #6168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jag96
reviewed
Nov 2, 2021
yuwenmemon
force-pushed
the
yuwen-https
branch
from
aa33d15 to
3dbf0a9
Compare
yuwenmemon
changed the title
Jag96
approved these changes
Nov 2, 2021
francoisl
approved these changes
Nov 2, 2021
|
|
github-actions bot
pushed a commit
that referenced
this pull request
Nov 2, 2021
Use git+https when loading expensify-common (cherry picked from commit e04b94f)
This was referenced Nov 2, 2021
|
🚀 Cherry-picked to staging by @yuwenmemon in version: 1.1.12-3 🚀
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes. |
19 tasks
|
🚀 Deployed to production by @yuwenmemon in version: 1.1.12-3 🚀
|
|
🚀 Deployed to staging by @yuwenmemon in version: 1.1.12-4 🚀
|
|
🚀 Deployed to production by @yuwenmemon in version: 1.1.13-2 🚀
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@francoisl @Jag96
Details
Looks like we hit a brownout related to: https://github.blog/2021-09-01-improving-git-protocol-security-github/
We need to stop using the unencrypted
git://protocol. Move us over togit+https://.Fixed Issues
None, but fixes the failing deploy here: https://github.com/Expensify/App/runs/4074554859
Tests
Ran
npm installin the/Apprepo, made sure it was successful.