Wrap PDF in TouchableWithoutFeedback #6169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prevents two finger touch event to bubble up
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
parasharrajat
suggested changes
Nov 2, 2021
Luke9389
reviewed
Nov 2, 2021
Luke9389
approved these changes
Nov 2, 2021
Luke9389
changed the title
|
@CamilaRivera we have a [HOLD] on merging right now that's expected to last about a week and a half or so. (Just FYI) |
Ok, thanks @Luke9389 for letting me know! |
Luke9389
approved these changes
Nov 10, 2021
|
@Luke9389 This is awaiting merge. |
|
@CamilaRivera Could you please attach the screen recording in the description of the fix? |
Luke9389
approved these changes
Nov 19, 2021
Luke9389
changed the title
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to production by @roryabraham in version: 1.1.16-10 🚀
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Trap events bubbling up from PDF preview to avoid opening the context menu with two fingers.
Fixed Issues
$ #5870
Tests | QA Steps
Tested On
Screenshots
Web
Mobile Web
Desktop
iOS
Android