Updated logic so when attendee deselected it will not move below attendee up #6173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ndee up Corrected this problem i.e. When an attendee is deselected below attendee is moving up 1 position in the list.
tgolen
approved these changes
Nov 2, 2021
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
19 tasks
|
🚀 Deployed to production by @yuwenmemon in version: 1.1.13-2 🚀
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@puneetlath @tgolen PR is ready for review.
Details
From Group split bill when an attendee is deselected at that time below attendee within deselected list is moving up 1 position in the list. So correct that problem.
Proposal: #6120 (comment)
Approval: #6120 (comment)
Fixed Issues
$ #6120
Tests | QA Steps
Now when an attendee deselected at that time below attendee will not move up 1 position in the list.
Tested On
Screenshots
Web
Web.mov
Mobile Web
MobileWeb.mov
Desktop
Desktop.mov
iOS
iOS.mov
Android
Android.mov