Allow users to enter addresses manually when needed #6210
Conversation
| if (!isValidAddress(this.state.addressStreet)) { | ||
| errors.addressStreet = true; | ||
| } | ||
|
|
||
| if (!isValidZipCode(this.state.addressZipCode)) { | ||
| errors.addressZipCode = true; | ||
| } |
There was a problem hiding this comment.
Can probably condense this to the following, unless you specifically want errors.addressStreet to be undefined instead of false after this runs.
| if (!isValidAddress(this.state.addressStreet)) { | |
| errors.addressStreet = true; | |
| } | |
| if (!isValidZipCode(this.state.addressZipCode)) { | |
| errors.addressZipCode = true; | |
| } | |
| errors.addressStreet = !isValidAddress(this.state.addressStreet) || !isValidZipCode(this.state.addressZipCode); |
There was a problem hiding this comment.
? I'm a bit confused. Why do you want to get rid of errors.addressZipCode?
|
@Gonals Also, I would test this out on Mobile Web, iOS, and (if possible) Android. Mobile Web Safari and iOS can sometimes handle rendering certain styles differently, such as flexbox. If you tested with a Chromium based browser for Web, then Android should be safe. Let me know if you need help with this; I have physical iOS and Android devices. |
Hey! I tested in Android (and chrome on android), but my iOS simulator is not having it today (just deciding not to launch), so I'll take you up on your offer! Could you check if it works fine on your physical device? |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by @jasperhuangg in version: 1.1.14-5 🚀
|
|
🚀 Deployed to production by @AndrewGable in version: 1.1.15-15 🚀
|
cc @tgolen
Fixed Issues
$ https://github.com/Expensify/Expensify/issues/183067
$ https://github.com/Expensify/Expensify/issues/183908
Tests
Connect Bank account. You can use our test accountCompany informationstep.Company addressfield still works as expected: You should be able to select an address from the drop-down menu and move to the next step. Entering a free text address should stop you from moving forward.Can't find your address? Enter it manually:Personal Informationstep. There's another address field in there. It should behave the sameQA Steps
Same as testing
Tested On