Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

padding using wrapperStyle #6237

Merged
merged 1 commit into from
Nov 5, 2021
Merged

padding using wrapperStyle #6237

merged 1 commit into from
Nov 5, 2021

Conversation

Santhosh-Sellavel
Copy link
Collaborator

Details

PR #6196 caused a regression, so fixing the regression using the solution already provided here. First just passing the style using wrapperStyle

Fixed Issues

$ #5906
$ #6232

Tests & QA Steps

  1. Go to Settings -> Payments
  2. Click on Add Payment method
  3. In Web / Desktop, the payment option's full width will be responsive now.

Tested On

  • Web
  • Desktop

Screenshots

Web

Screen.Recording.2021-11-05.at.12.26.57.PM.mov

Desktop

Screen.Recording.2021-11-05.at.12.31.40.PM.mov

@Santhosh-Sellavel Santhosh-Sellavel requested a review from a team as a code owner November 5, 2021 07:28
@MelvinBot MelvinBot requested review from deetergp and removed request for a team November 5, 2021 07:28
timszot
timszot approved these changes Nov 5, 2021
View reviewed changes
Copy link
Contributor

@timszot timszot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@timszot timszot merged commit 3d22037 into Expensify:main Nov 5, 2021
@OSBotify
Copy link
Contributor

OSBotify commented Nov 5, 2021

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions bot pushed a commit that referenced this pull request Nov 8, 2021
Merge pull request #6237 from Santhosh-Sellavel/Improve_Payment_Optio…
272b16d 
…ns_Floating_Button

padding using wrapperStyle

(cherry picked from commit 3d22037)
@OSBotify OSBotify mentioned this pull request Nov 8, 2021
Merged
@OSBotify
Copy link
Contributor

OSBotify commented Nov 8, 2021

🚀 Cherry-picked to staging by @francoisl in version: 1.1.14-3 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@OSBotify OSBotify mentioned this pull request Nov 15, 2021
Closed
70 tasks
@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @timszot in version: 1.1.14-5 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@botify botify mentioned this pull request Nov 15, 2021
Closed
@OSBotify
Copy link
Contributor

🚀 Deployed to production by @Jag96 in version: 1.1.14-4 🚀

platform result
🤖 android 🤖 failure ❌
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @AndrewGable in version: 1.1.15-15 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify OSBotify mentioned this pull request Aug 16, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timszot timszot timszot approved these changes

@deetergp deetergp Awaiting requested review from deetergp

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Santhosh-Sellavel @OSBotify @timszot