-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix language selector #6267
Fix language selector #6267
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works great and LGTM!
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
We are using props.translate('preferencesPage.language'); instead of importing |
Yes we can use it! |
The accessibility issue found in this PR:
|
🚀 Deployed to production by @AndrewGable in version: 1.1.15-15 🚀
|
cc @roryabraham
Details
Pass proper arguments
Fixed Issues
Unable to load Language picker page in preferences on main
#6234 (comment)
Tests / QA Steps
Tested On
Screenshots
Web
Mobile Web
Desktop
iOS
Android