Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-add autoFocus prop for ExpensiText components #6300

Merged
merged 2 commits into from
Nov 15, 2021
Merged

Conversation

Jag96
Copy link
Contributor

@Jag96 Jag96 commented Nov 15, 2021

@roryabraham will you please review this?

Details

This is a regression from 2231d55, we just need to ensure that autoFocus is still included.

Fixed Issues

$ #6298

Tests/QA

  1. Log in and open a chat
  2. Click on the + button and select Request Money or Send Money
  3. Enter a value and hit Next
  4. Confirm that the What's It For input on the following screen autoFocuses and you can see both the label and the placeholder

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web Mobile
image image

@Jag96 Jag96 requested review from roryabraham and a team November 15, 2021 18:32
@Jag96 Jag96 self-assigned this Nov 15, 2021
@MelvinBot MelvinBot requested review from MonilBhavsar and removed request for a team November 15, 2021 18:33
@roryabraham roryabraham merged commit 1e07a84 into main Nov 15, 2021
@roryabraham roryabraham deleted the joe-fix-autoFocus branch November 15, 2021 19:21
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @roryabraham in version: 1.1.14-5 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@ogumen
Copy link

ogumen commented Nov 22, 2021

The accessibility issues found in this PR:
Web/mWeb/Android

  1. The focus should be set to the first interactive element of the newly opened overlay ("Back" button) instead of auto-focusing the text field - failure of WCAG SC 2.4.3.
    https://user-images.githubusercontent.com/88733897/142882486-5e421ad1-342f-4124-95fb-f536a47154e0.mp4
    https://user-images.githubusercontent.com/88733897/142884550-04f1fe4a-4518-47ef-b3fb-3f8a6d93afdc.mp4

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @AndrewGable in version: 1.1.15-15 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants