-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add /partners/plaid/oauth_ios to apple-app-site-association #6366
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Looks like in #5077 we could QA on staging, so going to update the tests to ask QA to test there. Also, I filed https://github.com/Expensify/Expensify/issues/185770 as a separate issue to update this file's syntax to be in line w/ the new apple standard.
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
Going to CP this to test on staging for testing |
Add /partners/plaid/oauth_ios to apple-app-site-association (cherry picked from commit f9b0e1a)
🚀 Cherry-picked to staging by @Jag96 in version: 1.1.15-9 🚀
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes. |
Just tested this BTW on iOS myself and can verify it works. |
I did this my sending an imessage to myself with just |
🚀 Deployed to production by @AndrewGable in version: 1.1.15-15 🚀
|
🚀 Deployed to production by @roryabraham in version: 1.1.16-10 🚀
|
@Jag96
cc @TomatoToaster
Fixed Issues
$ https://github.com/Expensify/Expensify/issues/182955
Tests
None, will test on staging.
QA Steps
Go to
https://staging.new.expensify.com/partners/plaid/oauth_ios
on an iOS device, confirm the New Expensify App opens. This does not need to be QA'd on any other platform.Tested On
Screenshots
Web
Mobile Web
Desktop
iOS
Android