Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add /partners/plaid/oauth_ios to apple-app-site-association #6366

Merged
merged 1 commit into from
Nov 19, 2021

Conversation

Gonals
Copy link
Contributor

@Gonals Gonals commented Nov 19, 2021

@Jag96

cc @TomatoToaster

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/182955

Tests

None, will test on staging.

QA Steps

Go to https://staging.new.expensify.com/partners/plaid/oauth_ios on an iOS device, confirm the New Expensify App opens. This does not need to be QA'd on any other platform.

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

Mobile Web

Desktop

iOS

Android

@Gonals Gonals requested a review from a team as a code owner November 19, 2021 09:57
@Gonals Gonals self-assigned this Nov 19, 2021
@MelvinBot MelvinBot requested review from stitesExpensify and removed request for a team November 19, 2021 09:58
@Gonals Gonals requested review from Jag96 and removed request for stitesExpensify November 19, 2021 14:44
Copy link
Contributor

@Jag96 Jag96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Looks like in #5077 we could QA on staging, so going to update the tests to ask QA to test there. Also, I filed https://github.com/Expensify/Expensify/issues/185770 as a separate issue to update this file's syntax to be in line w/ the new apple standard.

@Jag96 Jag96 merged commit f9b0e1a into main Nov 19, 2021
@Jag96 Jag96 deleted the alberto-linkIos branch November 19, 2021 19:11
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@Jag96
Copy link
Contributor

Jag96 commented Nov 19, 2021

Going to CP this to test on staging for testing

github-actions bot pushed a commit that referenced this pull request Nov 19, 2021
Add /partners/plaid/oauth_ios to apple-app-site-association

(cherry picked from commit f9b0e1a)
@OSBotify
Copy link
Contributor

🚀 Cherry-picked to staging by @Jag96 in version: 1.1.15-9 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@TomatoToaster
Copy link
Contributor

Just tested this BTW on iOS myself and can verify it works.

@TomatoToaster
Copy link
Contributor

I did this my sending an imessage to myself with just https://staging.new.expensify.com/partners/plaid/oauth_ios and then clicking on the link and it opened up the NewDot app 👍🏾

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @AndrewGable in version: 1.1.15-15 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @Jag96 in version: 1.1.15-18 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @roryabraham in version: 1.1.16-10 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants