Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue where users not displaying in iOS chat switcher #637

Merged
merged 1 commit into from
Oct 14, 2020
Merged

Fix issue where users not displaying in iOS chat switcher #637

merged 1 commit into from
Oct 14, 2020

Conversation

Julesssss
Copy link
Contributor

CC @cead22 -- I believe this was introduced during the API refactor

Fixes issue where no users were listed in the chat switcher for iOS.

  • Fix broken personalDetails API request, to prevent empty response from overriding personal user data
  • Each platform would receive an empty response and I'm still not sure why this only affected iOS 🤷‍♂️

Fixed Issues

Fixes https://github.com/Expensify/Expensify/issues/142350

Tests

Screenshots

Before
Simulator Screen Shot - iPhone 11 - 2020-10-13 at 15 10 22

After
Simulator Screen Shot - iPhone 11 - 2020-10-13 at 15 10 43

@Julesssss Julesssss requested a review from a team October 13, 2020 14:12
@Julesssss Julesssss self-assigned this Oct 13, 2020
@botify botify requested review from Dal-Papa and removed request for a team October 13, 2020 14:13
@tgolen tgolen removed their request for review October 13, 2020 16:37
@Julesssss
Copy link
Contributor Author

Hey @Dal-Papa, Andrew is off this week. Are you happy to merge, or would you like me to find a second reviewer?

@Dal-Papa
Copy link

Hey @Dal-Papa, Andrew is off this week. Are you happy to merge, or would you like me to find a second reviewer?

I'm not the most proficient so not sure how much value you get from my review. Also aren't code owners needed for merging ? (seems like not but just to be sure)

stitesExpensify
stitesExpensify approved these changes Oct 14, 2020
View reviewed changes
Copy link
Contributor

@stitesExpensify stitesExpensify left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine to me! Good catch!

@stitesExpensify
Copy link
Contributor

Testing real quick before I merge

@stitesExpensify stitesExpensify merged commit 4b27f0c into master Oct 14, 2020
@stitesExpensify stitesExpensify deleted the jules-fix-ios-chat-switcher branch October 14, 2020 15:43
@Julesssss
Copy link
Contributor Author

Thank you!

@Taimoor0217 Taimoor0217 mentioned this pull request Feb 16, 2024
Open
@atef1995 atef1995 mentioned this pull request Feb 17, 2024
Open
@osama256 osama256 mentioned this pull request Feb 17, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stitesExpensify stitesExpensify stitesExpensify approved these changes

@Dal-Papa Dal-Papa Dal-Papa approved these changes

@AndrewGable AndrewGable Awaiting requested review from AndrewGable

Assignees

@Julesssss Julesssss

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Julesssss @Dal-Papa @stitesExpensify