Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[No QA] Create Form and FormActions #6412

Merged
merged 73 commits into from
Feb 1, 2022
Merged

[No QA] Create Form and FormActions #6412

merged 73 commits into from
Feb 1, 2022

Conversation

luacmartins
Copy link
Contributor

@luacmartins luacmartins commented Nov 23, 2021

Details

Implements Form as instructed in the design doc.

cc @marcaaron @roryabraham would you please review?

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/193359
$ https://github.com/Expensify/Expensify/issues/193360
$ https://github.com/Expensify/Expensify/issues/193361

Tests

  1. Run npm run storybook

  2. Play around with the Form stories and make sure that it works as intended. Specifically, note the following:

    • We can enter values into the inputs.
    • Clicking submit displays a loading indicator in the submit button and an alert with the correct input values.
    • Emptying the input value and blurring it shows an error.
    • Clicking the fix the errors link above the submit button focus on the first input with an error.
    • Entering a value in the input clears the error.
    • Verify that server errors are displayed correctly.
    • Any other fishy behavior.
  3. Run the app and test that TextInput still works fine.

QA Steps

Regular regression tests, looking for any weird behavior on text inputs.

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

Mobile Web

Desktop

iOS

Android

@luacmartins luacmartins self-assigned this Nov 23, 2021
Copy link
Contributor

@roryabraham roryabraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the one remaining comment I think this is lookin' good

src/components/Form.js Outdated Show resolved Hide resolved
roryabraham
roryabraham previously approved these changes Feb 1, 2022
src/components/Form.js Show resolved Hide resolved
src/components/Form.js Outdated Show resolved Hide resolved
src/components/Form.js Outdated Show resolved Hide resolved
src/components/Form.js Show resolved Hide resolved
@luacmartins
Copy link
Contributor Author

Addressed @marcaaron latest comments. I added the decorators in BaseTextInput.

@luacmartins
Copy link
Contributor Author

Updated!

@marcaaron marcaaron merged commit ef91a04 into main Feb 1, 2022
@marcaaron marcaaron deleted the cmartins-form branch February 1, 2022 23:48
@OSBotify
Copy link
Contributor

OSBotify commented Feb 1, 2022

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

OSBotify commented Feb 2, 2022

🚀 Deployed to staging by @marcaaron in version: 1.1.35-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

OSBotify commented Feb 4, 2022

🚀 Deployed to production by @sketchydroide in version: 1.1.35-1 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@zanyrenney
Copy link
Contributor

This issue caused this bug: First field is not focused after clicking the fix the errors link on Connect Manually page ##12400

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants