-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[No QA] Create Form and FormActions #6412
Conversation
4a83029
to
f5c7bef
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than the one remaining comment I think this is lookin' good
…dd value decorators
Addressed @marcaaron latest comments. I added the decorators in |
Updated! |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by @marcaaron in version: 1.1.35-0 🚀
|
🚀 Deployed to production by @sketchydroide in version: 1.1.35-1 🚀
|
This issue caused this bug: First field is not focused after clicking the fix the errors link on Connect Manually page ##12400 |
Details
Implements Form as instructed in the design doc.
cc @marcaaron @roryabraham would you please review?
Fixed Issues
$ https://github.com/Expensify/Expensify/issues/193359
$ https://github.com/Expensify/Expensify/issues/193360
$ https://github.com/Expensify/Expensify/issues/193361
Tests
Run
npm run storybook
Play around with the Form stories and make sure that it works as intended. Specifically, note the following:
fix the errors
link above the submit button focus on the first input with an error.Run the app and test that TextInput still works fine.
QA Steps
Regular regression tests, looking for any weird behavior on text inputs.
Tested On
Screenshots
Web
Mobile Web
Desktop
iOS
Android