Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NO QA] fix: crash #6462

Merged
merged 1 commit into from
Nov 24, 2021
Merged

[NO QA] fix: crash #6462

merged 1 commit into from
Nov 24, 2021

Conversation

parasharrajat
Copy link
Member

Details

Regression from #6112.

Fixed Issues

$ GH_LINK

Tests

QA Steps

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • [x Android

Screenshots

Web

Mobile Web

Desktop

iOS

Android

@parasharrajat parasharrajat requested a review from a team as a code owner November 24, 2021 18:09
@MelvinBot MelvinBot requested review from Beamanator and removed request for a team November 24, 2021 18:09
Copy link
Contributor

@roryabraham roryabraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad, I should've done a final test on iOS/Android. I was only regularly testing on web/desktop, because that's where the modal was introduced. Bad Rory, bad!

@parasharrajat
Copy link
Member Author

parasharrajat commented Nov 24, 2021

Bad Rory, bad!

More like,,,,, Busy Rory, Busy!

@roryabraham roryabraham merged commit cc78af2 into Expensify:main Nov 24, 2021
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @roryabraham in version: 1.1.16-11 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

OSBotify commented Dec 6, 2021

🚀 Deployed to production by @roryabraham in version: 1.1.17-7 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants