-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix infinite loop in withFullPolicy HOC #6531
Conversation
I personally think this issue is severe enough that we should CP the fix to staging. |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM and works well
Discussed 1:1 with rory and we feel like this should go out the door sooner (context). So gonna go ahead and merge this now. |
…lPolicy Fix infinite loop in withFullPolicy HOC (cherry picked from commit 8d8395f)
🚀 Deployed to staging by @chiragsalian in version: 1.1.17-8 🚀
|
🚀 Deployed to production by @roryabraham in version: 1.1.18-3 🚀
|
Details
We were previously relying on a route's
path
param (the visible path for the route in the URL). The problem is that param is optional, and is only present if the app is opened via a deep-link (or via direct URL manipulation on web). Instead, we'll rely on the route name, which is required, and the route params, which will be there if provided.Fixed Issues
$ #6526
Tests
Click on an existing workspace. Verify using logs or the network console that the full policy is loaded.
Click on a workspace sub-page. Verify using logs or the network console that no full policy is loaded.
Refresh the page on one of the workspace sub-pages. Verify using logs or the network console that the full policy is loaded.
Click on the x to close the modal. Verify that the full settings modal closes.
QA Steps
GET
requests to fetch a policy.Tested On