P2P Enable adding deposit account as payment method #6638
Conversation
marcaaron
changed the title
marcaaron
changed the title
marcaaron
changed the title
Refactor Add Payment method menu and link to add personal bank account flow. fix password requirement on plaid modal. Rm console.log Only add ability to add deposit account for now require password param add password requirement back to plaid form but make it optional add some loading spinner polish
marcaaron
force-pushed
the
marcaaron-kycUpgradeFlow
branch
from
5080dfd to
9aa0509
Compare
marcaaron
changed the title
|
Putting this into reviews while I continue to test on other platforms. |
|
This is probably not a blocker, but one interesting / weird thing discovered while testing is that on Android (but not any other platform) the plaid payments list shows "Wells Fargo" and the correct icon is not displayed. :lolwut: |
|
Sounds good, thanks @ctkochan22. Re-rolling with PullerBear to get another set of eyes. 🙇 |
There was a problem hiding this comment.
Code LGTM, shouldn't interfere with my projects. Leaving it to @nickmurray47 for final review
| PaymentMethods.getPaymentMethods() | ||
| .then(() => { | ||
| Navigation.goBack(); | ||
| Onyx.merge(ONYXKEYS.REIMBURSEMENT_ACCOUNT, {loading: false}); |
There was a problem hiding this comment.
Do we want success growls here?
There was a problem hiding this comment.
Dang yea that would probably be a nice touch. It's pretty strange that we just kick you back to the payments page now that I think about it. But it works for now.
| Onyx.merge(ONYXKEYS.REIMBURSEMENT_ACCOUNT, {loading: false}); | ||
| }) | ||
| .catch(() => { | ||
| Onyx.merge(ONYXKEYS.REIMBURSEMENT_ACCOUNT, {loading: false}); |
| isVisible: PropTypes.bool.isRequired, | ||
| onClose: PropTypes.func.isRequired, | ||
| anchorPosition: PropTypes.shape({ | ||
| top: PropTypes.number, | ||
| left: PropTypes.number, | ||
| }), |
|
🚀 Deployed to staging by @yuwenmemon in version: 1.1.18-6 🚀
|
|
🚀 Deployed to production by @Julesssss in version: 1.1.21-1 🚀
|
cc @stitesExpensify @nickmurray47 if you guys want to also take a look to make sure this will line up with any active changes for "Send Money" and "Payment Methods".
Details
Adds the ability to set up a personal bank account via the payments page
Fixed Issues
$ https://github.com/Expensify/Expensify/issues/187883
Tests / QA Steps
expensify.comsite asnew.expensify.comdoes not yet allow removing payment methods).Settings > Payments > Add payment methodand select "Bank account"Tested On
Screenshots
Web
Mobile Web
Desktop
iOS
Android