Open modal to join screen share requests from GuidesPlus agents

[francoisl]

cc @tjferriss

Details

• Listen to screen share invites sent by GuidesPlus agents. When joined, open OldDot in a new tab, where all the code to join screen shares already exists.

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/184039

Tests

Needs the Web-E PR https://github.com/Expensify/Web-Expensify/pull/32573. Tests steps

QA Steps

Regular staging QA: make sure there are no regressions in NewDot potentially introduced by this PR.

Internal QA (since it requires EW access - I can do this part myself): follow QA steps from the Web-E PR.

Tested On

• Web
• Mobile Web
• Desktop
• iOS
• Android

Screenshots

See the recording in https://github.com/Expensify/Web-Expensify/pull/32573 for the full flow

[francoisl]

Updated, thanks.

I'm seeing a warning for the propTypes in the console that makes 0 sense when I receive the push notification:

Failed prop type: Invalid prop `screenShareRequest.accessToken` of type `string` supplied to `Expensify`, expected `object`.

screenShareRequest.accessToken is expected to be a string according to the code, not an object. Also, a string is supplied. Do you happen to have any idea? Kinda stumped on this one.

[marcochavezf]

Updated, thanks.

I'm seeing a warning for the propTypes in the console that makes 0 sense when I receive the push notification:

Failed prop type: Invalid prop `screenShareRequest.accessToken` of type `string` supplied to `Expensify`, expected `object`.

screenShareRequest.accessToken is expected to be a string according to the code, not an object. Also, a string is supplied. Do you happen to have any idea? Kinda stumped on this one.

Ah we'll need to use only PropTypes.shape, something like:

    screenShareRequest: PropTypes.shape({

        /** Access token required to join a screen share room, generated by the backend */
        accessToken: PropTypes.string,

        /** Name of the screen share room to join */
        roomName: PropTypes.string,
    }),

because PropTypes.objectOf is used when we don't know the name of the properties ahead of time, but in this case we already know screenShareRequest has only the properties accessToken and roomName. https://stackoverflow.com/questions/45764746/react-proptypes-objectof-vs-shape

[francoisl]

Oooh got it, thanks, that makes sense. The PR is updated, but still on hold.

[francoisl]

Ok this is ready to go, the PR it depended on is on production on Web-E now. I also fixed the conflict in this PR.

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[OSBotify]

🚀 Deployed to staging by @marcochavezf in version: 1.1.20-3 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

[mvtglobally]

@francoisl, @marcochavezf Can you please validate this internally as well and check off

[francoisl]

Tested just now with @leminhphong, worked like a charm!

[OSBotify]

🚀 Deployed to production by @Julesssss in version: 1.1.21-1 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅