Add some hitSlop around the send button #6708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roryabraham
commented
Dec 10, 2021
| onPress={this.submitForm} | ||
| underlayColor={themeColors.componentBG} | ||
| disabled={this.state.isCommentEmpty || isBlockedFromConcierge || isArchivedChatRoom} | ||
| hitSlop={{top: 3, right: 3, bottom: 3, left: 3}} |
There was a problem hiding this comment.
The docs say that you should be able to pass a single number here, but that caused a crash when I tried it.
|
@deetergp I just fixed the lint errors here, ready for review |
roryabraham
commented
Dec 14, 2021
| onPress={this.submitForm} | ||
| underlayColor={themeColors.componentBG} | ||
| disabled={this.state.isCommentEmpty || isBlockedFromConcierge || isArchivedChatRoom} | ||
| hitSlop={{ | ||
| top: 3, right: 3, bottom: 3, left: 3, |
There was a problem hiding this comment.
Note that 3 is chosen because it matches the margin around the button. That's the max hitSlop we can add because it cannot extend beyond the bounds of the parent component.
deetergp
approved these changes
Dec 15, 2021
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
37 tasks
|
🚀 Deployed to production by @Julesssss in version: 1.1.21-1 🚀
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Adds some extra touchability margins around the "send chat" button.
Fixed Issues
$ #6662
Tests / QA Steps
Tested On
Screenshots
Web
Mobile Web
Desktop
iOS
Android