Update getSimplifiedPolicyObject to handle different policy objects #6739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MelvinBot
requested review from
sketchydroide
and removed request for
a team
roryabraham
requested changes
Dec 13, 2021
|
Updated |
marcaaron
approved these changes
Dec 14, 2021
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
37 tasks
|
@ctkochan22 @roryabraham @marcaaron Should we QA this PR on all platforms? |
|
Yes please @mvtglobally |
|
🚀 Deployed to staging by @marcaaron in version: 1.1.20-3 🚀
|
|
🚀 Deployed to production by @Julesssss in version: 1.1.21-1 🚀
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Expensify/pullerbear
cc @marcaaron @roryabraham (cc'ing bc thats what github suggested)
Originally updated Auth, but we have made it a point to handle it on the client side #6590 (comment)
So we are updating
getSimplifiedPolicyObjectto handle the different policy objects that "GetPolicySummaryList" and "GetFullPolicy" returns.Fixed Issues
App side fix GH_LINK
Tests / QA Steps
Prior to testing, create a workspace and add an avatar image.
Tested On
Screenshots
Web
Mobile Web
Desktop
iOS
Android