fix: Added translation for room visibility dropdown #6786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MelvinBot
requested review from
parasharrajat and
puneetlath
and removed request for
a team
parasharrajat
suggested changes
Dec 15, 2021
| @@ -129,6 +129,12 @@ class WorkspaceNewRoomPage extends React.Component { | |||
| return null; | |||
| } | |||
| const shouldDisableSubmit = Boolean(!this.state.roomName || !this.state.policyID || this.state.error); | |||
|
|
|||
| const visibilityOptions = _.map(_.values(CONST.REPORT.VISIBILITY), v => ({ | |||
There was a problem hiding this comment.
Can you please use a more descriptive name instead of v?
|
@parasharrajat PR updated. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
31 tasks
|
🚀 Deployed to staging by @puneetlath in version: 1.1.21-2 🚀
|
|
🚀 Deployed to production by @sketchydroide in version: 1.1.22-0 🚀
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Fixed Issues
$ #6733
Tests
QA Steps
Tested On
Screenshots
Web
Mobile Web
Desktop
iOS
Android