Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename expensify button #6788

Merged
merged 2 commits into from
Dec 17, 2021
Merged

Rename expensify button #6788

merged 2 commits into from
Dec 17, 2021

Conversation

mateusbra
Copy link
Contributor

Details

Rename component ExpensifyButton to Button

Fixed Issues

$ #6760

Tests

  1. Run the app and see that Buttons continue working.

QA Steps

  1. Run the app and see that Buttons continue working.

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

Captura de Tela 2021-12-15 às 19 12 45

Mobile Web

WhatsApp Image 2021-12-15 at 19 14 37

Desktop

Captura de Tela 2021-12-15 às 19 01 16

@mateusbra mateusbra requested a review from a team as a code owner December 15, 2021 22:22
@MelvinBot MelvinBot requested review from parasharrajat and puneetlath and removed request for a team December 15, 2021 22:22
parasharrajat
parasharrajat approved these changes Dec 15, 2021
View reviewed changes
Copy link
Member

@parasharrajat parasharrajat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please create separate PR for each milestone. Thanks.

cC: @puneetlath .

puneetlath
puneetlath reviewed Dec 16, 2021
View reviewed changes
Copy link
Contributor

@puneetlath puneetlath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me as well. However, can you test on the mobile apps as well for completeness. Once you do, I'll merge. Thanks!

@mateusbra
Copy link
Contributor Author

Tested in Android and IOS apps and it worked fine on both:
Android
WhatsApp Image 2021-12-17 at 12 59 42
IOS
Simulator Screen Shot - iPhone 12 - 2021-12-17 at 14 02 29

puneetlath
puneetlath approved these changes Dec 17, 2021
View reviewed changes
Copy link
Contributor

@puneetlath puneetlath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@puneetlath puneetlath merged commit d012bea into Expensify:main Dec 17, 2021
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@botify botify mentioned this pull request Dec 21, 2021
Closed
@OSBotify
Copy link
Contributor

🚀 Deployed to production by @sketchydroide in version: 1.1.22-2 🚀

platform result
🤖 android 🤖 cancelled 🔪
🖥 desktop 🖥 cancelled 🔪
🍎 iOS 🍎 cancelled 🔪
🕸 web 🕸 cancelled 🔪

@OSBotify OSBotify mentioned this pull request Dec 21, 2021
Closed
26 tasks
@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @puneetlath in version: 1.1.22-2 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @yuwenmemon in version: 1.1.23-1 🚀

platform result
🤖 android 🤖 failure ❌
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@parasharrajat parasharrajat parasharrajat approved these changes

@puneetlath puneetlath puneetlath approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mateusbra @OSBotify @puneetlath @parasharrajat