Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SelectCircle replace usage in OptionsRow and makes MenuItem selectable #6791

Merged
merged 4 commits into from
Dec 16, 2021

Conversation

marcaaron
Copy link
Contributor

Details

cc @parasharrajat Just adds SelectCircle. Small PR moved out of your other PR to help minimize changes.

Fixed Issues

No Issue

Tests / QA Steps

  1. Navigate to /new/group
  2. Select a user
  3. Verify the check mark looks normal
  4. De-select verify the check mark disappears

2021-12-15_14-33-48

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

Mobile Web

Desktop

iOS

Android

@marcaaron marcaaron self-assigned this Dec 16, 2021
@marcaaron marcaaron requested a review from a team as a code owner December 16, 2021 01:01
@MelvinBot MelvinBot requested review from jasperhuangg and removed request for a team December 16, 2021 01:01
@marcaaron marcaaron merged commit 7e0717f into main Dec 16, 2021
@marcaaron marcaaron deleted the marcaaron-selectCircle branch December 16, 2021 02:24
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @marcaaron in version: 1.1.21-2 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @sketchydroide in version: 1.1.22-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants