Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inverted flatlist at ReportActionsView with few items should stick to bottom of page #6798

Merged
merged 1 commit into from
Dec 16, 2021

Conversation

azimgd
Copy link
Contributor

@azimgd azimgd commented Dec 16, 2021

@thienlnam @alex-mechler

This fixes #6738 and #6792 where ReportActionsView with few items was sticking to top instead of bottom on native devices.

Details

Web-version of InvertedFlatList component has been using transform: translate while not on native devices. Adjusted styles to match the behavior on both web and native.

Fixed Issues

$ #6792

Tests

QA Steps

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

Screen Shot 2021-12-16 at 19 29 30

Mobile Web

simulator_screenshot_5F67D1E6-61E0-4487-8C8F-89C55EC96D1E

Desktop

iOS

simulator_screenshot_A9789813-E5D4-4E6A-AF21-C828F5317663

Android

@github-actions
Copy link
Contributor

⚠️ ⚠️ Heads up! This pull request has the CP Staging label. ⚠️ ⚠️
Merging it will cause it to be immediately deployed to staging, even if the open StagingDeployCash deploy checklist is locked.

@Julesssss
Copy link
Contributor

Ugh, I had trouble with both Android and iOS builds 😭

Testing well on iOS & web, let's merge.

@Julesssss Julesssss merged commit 11a708c into Expensify:main Dec 16, 2021
OSBotify pushed a commit that referenced this pull request Dec 16, 2021
Fix inverted flatlist at ReportActionsView with few items should stick to bottom of page

(cherry picked from commit 11a708c)
@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @Julesssss in version: 1.1.21-2 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @sketchydroide in version: 1.1.22-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants