Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken manual address on Additional Information page #6803

Merged
merged 2 commits into from
Dec 16, 2021

Conversation

luacmartins
Copy link
Contributor

Details

Tracks the manualAddress state for beneficial owners in the Additional Information page.

Fixed Issues

$ #6793

Tests

  1. Log into the app
  2. Select a Workspace and click on Connect bank account
  3. Fill in the form to get to the Additional Information page
  4. Select Somebody else owns more than 25% of ...
  5. Under the address field, click on Can't find your address? Enter it manually
  6. Verify that the fields for City, State and Zip code show up.

QA Steps

Steps above.

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

web.mov

Mobile Web

mweb.mov

Desktop

desktop.mov

iOS

ios.mov

Android

android.mov

@luacmartins luacmartins self-assigned this Dec 16, 2021
@luacmartins luacmartins marked this pull request as ready for review December 16, 2021 17:34
@luacmartins luacmartins requested a review from a team as a code owner December 16, 2021 17:34
@MelvinBot MelvinBot requested review from Jag96 and removed request for a team December 16, 2021 17:34
Copy link
Contributor

@Jag96 Jag96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Jag96 Jag96 merged commit 0b1e5d8 into main Dec 16, 2021
@Jag96 Jag96 deleted the cmartins-manualAddress branch December 16, 2021 19:51
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @Jag96 in version: 1.1.21-2 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @sketchydroide in version: 1.1.22-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants