Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove create new workspace button from workspace settings #6827

Merged
merged 1 commit into from
Dec 20, 2021

Conversation

luacmartins
Copy link
Contributor

@luacmartins luacmartins commented Dec 17, 2021

Details

We only allow users to have one Workspace. However, users are able to create multiple Workspaces by using the three dot menu on the Workspace Settings page. This PR removes that button since users that can navigate to the Workspace settings page already have a Workspace.

I also updated the delete Workspace button color to red, instead of the current green.

Fixed Issues

$ #6818

Tests

  1. Log into the App.
  2. Create a Workspace.
  3. Click on Profile > Select Workspace > Three dot menu
  4. Verify that the New Workspace button is no longer visible.

QA Steps

Steps above.

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

web.mov

Mobile Web

mweb.mov

Desktop

desktop.mov

iOS

ios.mov

Android

android.mov

@luacmartins luacmartins self-assigned this Dec 17, 2021
@luacmartins luacmartins marked this pull request as ready for review December 17, 2021 23:20
@luacmartins luacmartins requested a review from a team as a code owner December 17, 2021 23:20
@MelvinBot MelvinBot requested review from MonilBhavsar and removed request for a team December 17, 2021 23:20
@MonilBhavsar MonilBhavsar merged commit d0fb604 into main Dec 20, 2021
@MonilBhavsar MonilBhavsar deleted the cmartins-removeCreateNewWorkspaceButton branch December 20, 2021 07:10
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @sketchydroide in version: 1.1.22-2 🚀

platform result
🤖 android 🤖 cancelled 🔪
🖥 desktop 🖥 cancelled 🔪
🍎 iOS 🍎 cancelled 🔪
🕸 web 🕸 cancelled 🔪

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @MonilBhavsar in version: 1.1.22-2 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@mvtglobally
Copy link

@luacmartins, Just to confirm. Since this PR was reverted, we should still see the button, right?

@luacmartins
Copy link
Contributor Author

That's correct! Thanks for confirming!

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @yuwenmemon in version: 1.1.23-1 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 failure ❌
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @yuwenmemon in version: 1.1.23-1 🚀

platform result
🤖 android 🤖 failure ❌
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants