Skip to content

[No QA] Update copy on terms page #6830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 20, 2021
Merged

[No QA] Update copy on terms page #6830

merged 1 commit into from
Dec 20, 2021

Conversation

Jag96
Copy link
Contributor

@Jag96 Jag96 commented Dec 18, 2021

Details

This PR updates 2 copy sections for the terms page of the VBA flow, specifically the updates in this comment. I've also added a screenshot to confirm that expensify.cash is not on the terms page and new.expensify.com is shown instead.

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/167278

Tests

Go through the VBA flow, confirm that the copy is updated.

QA Steps

No QA

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

image image

@Jag96 Jag96 requested a review from a team December 18, 2021 00:48
@Jag96 Jag96 self-assigned this Dec 18, 2021
@MelvinBot MelvinBot requested review from aldo-expensify and removed request for a team December 18, 2021 00:48
Copy link
Contributor

@aldo-expensify aldo-expensify left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@aldo-expensify aldo-expensify merged commit 6fbbbc7 into main Dec 20, 2021
@aldo-expensify aldo-expensify deleted the joe-terms-page-copy branch December 20, 2021 19:46
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @sketchydroide in version: 1.1.22-2 🚀

platform result
🤖 android 🤖 cancelled 🔪
🖥 desktop 🖥 cancelled 🔪
🍎 iOS 🍎 cancelled 🔪
🕸 web 🕸 cancelled 🔪

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @aldo-expensify in version: 1.1.22-2 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @yuwenmemon in version: 1.1.23-1 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 failure ❌
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @yuwenmemon in version: 1.1.23-1 🚀

platform result
🤖 android 🤖 failure ❌
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants