-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename ExpensiTextInput #6838
Rename ExpensiTextInput #6838
Conversation
We had a lint error due to having two style names that are the same: |
you can try baseTextInput if that works. |
It looks like we previously did it as App/src/components/ExpensifyText.js Line 5 in d28716a
So maybe that's a good format to follow for when we import these components from React Native? |
You're saying we should change these imports: App/src/components/ExpensiTextInput/BaseExpensiTextInput.js Lines 3 to 5 in d28716a
into: import {
Animated as AnimatedRN,
View as ViewRN,
TouchableWithoutFeedback as TouchableWithoutFeedbackRN,
Pressable as PressableRN,
} from 'react-native'; Is that what you're proposing? @puneetlath |
Ah perhaps I've misunderstood. Can you help me understand why we need to call the files |
@puneetlath our file structure will be this: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small changes...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
cc: @puneetlath
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mateusbra thanks for your patience through the holidays. Everything looks good to me, but you've picked up some merge conflicts. Once you fix those I can quickly re-approve and merge. Thanks!
…> TextInput in AddressForm.js and AddDebitCardPage.js
4047edb
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by @puneetlath in version: 1.1.25-2 🚀
|
Details
Rename component
ExpensiTextInput
toTextInput
Fixed Issues
$ #6760
Tests
QA Steps
Tested On
Screenshots
Web
Mobile Web
Desktop
iOS
Android