Email address is cutoff on iOS on Login #686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shawnborton
reviewed
Oct 21, 2020
src/styles/StyleSheet.js
Outdated
| @@ -221,7 +221,10 @@ const styles = { | |||
| borderColor: colors.text, | |||
| borderWidth: 1, | |||
| color: colors.textReversed, | |||
| padding: 12, | |||
| paddingLeft: 12, | |||
There was a problem hiding this comment.
These new rules should be applied to the textInput above (so all textInputs get these global changes), and we should save rules for textInputReversed to only control color styles.
There was a problem hiding this comment.
So I think I should remove everything from textInputReversed that is not relative to colors then
There was a problem hiding this comment.
That makes sense to me.
|
Screenshots please! |
|
Screenshots:
|
shawnborton
approved these changes
Oct 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Email address is cutoff at the bottom during log in on iOS
Fixed Issues
Fixes https://github.com/Expensify/Expensify/issues/143769
Tests (iOS)
gorporjalsoT