[No QA] Cleanup implementation of HTMLEngineProvider #6885
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roryabraham
commented
Dec 22, 2021
roryabraham
commented
Dec 28, 2021
roryabraham
changed the title
# Conflicts: # src/components/HTMLEngineProvider/BaseHTMLEngineProvider.js
MelvinBot
requested review from
stitesExpensify
and removed request for
a team
# Conflicts: # src/components/HTMLEngineProvider/BaseHTMLEngineProvider.js
|
Merged main again to keep up-to-date and make sure tests pass, but there were no conflicts. Small bump @stitesExpensify |
stitesExpensify
approved these changes
Jan 19, 2022
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
33 tasks
|
🚀 Deployed to staging by @stitesExpensify in version: 1.1.31-2 🚀
|
|
🚀 Deployed to production by @AndrewGable in version: 1.1.32-0 🚀
|
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
This PR cleans up the
HTMLEngineProvidercomponent implementation to make it align with the one-component-per-file convention we have throughout the rest of our codebase. There was a seemingly arbitrary exception made inHTMLEngineProvider, and it made the component very large and harder to scan/reason about.Fixed Issues
$ n/a
Tests
QA Steps
Just regression tests.
Tested On
Screenshots
Web
Mobile Web
Desktop
iOS
Android