-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NO QA]Manually update staging to use new GPG key in cherry pick workflow #6961
Conversation
How do Cherry pick fix: room page layout #6951? Do you manually create a new PR from branch |
@aldo-expensify mobile deployers can run a manual cherry pick here: https://github.com/Expensify/App/actions/workflows/cherryPick.yml I've kicked one off here! |
Thanks! |
It died, right? 😆 Update: oh no, it is fine I think: https://github.com/Expensify/App/pull/6964/files, do you want me to push a commit resolving the conflicts? |
It did die, but I forgot to delete the branch Yes, can you resolve the conflicts and merge the PR? |
🚀 Cherry-picked to staging by @AndrewGable in version: 1.1.24-8 🚀
|
🚀 Deployed to production by @francoisl in version: 1.1.24-8 🚀
|
Details
Due to the way the deploy process works, we do not update the staging branch once the checklists are running, however we do update the GitHub workflow code on merge. This has caused a discrepancy in the workflow code and the GPG key on staging. This will update the key and code to match on staging, allowing us to test following these steps: https://github.com/Expensify/Expensify/issues/190171
Fixed Issues
$ https://github.com/Expensify/Expensify/issues/190171#issuecomment-1003165197
Tests
QA Steps
N/A